Adding Waveshare35c LCD support in dietpi-config and dietpi-set_hardware #7508
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code for the Waveshare32 was duplicated and modified to support the very similar Waveshare35c model. I only have the hardware to test on a RPi, and so I was unable to test these changes on any other hardware configurations.
I also needed to modify the framebuffer identifier in dietpi-set_hardware to be
/dev/fb0
instead of the/dev/fb1
that's set in the same Waveshare32 code. I have no idea why there was this discrepancy, and I did not make a similar change to the equivalent odroids code, because I could not test to see if that was required - so, this might be an area for improvement and for someone with more knowledge than I to scrutinize.