Merge dev to main for release 2024.1 #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the last 'always' block of WideMultTopPf_Tb.sv, result checking is performed when 'result' changes, and 'check_result_widemult' (the golden) is supposed to change at the same time. In some simulation mode of ModelSim, we encountered a situation that value change of both 'result' and 'check_result_widemult' happen at the same time, but 'check_result_widemult' still holds the old value when simulation execution control goes into the 'always @(result)' block. To avoid this simulation implementation issue affects the correctness of this testbench, an extra statement, '@(negedge SYSCLK)' is added in the beginning of the 'always @(result)' block body, to delay result checking to the next negedge clock to make sure 'check_result_widemult' is settled.
Fix testbench of wide_mult in Training3
…xi_target_linda Add '-D__STDC_FORMAT_MACROS' to USER_CXX_FLAG of axi_target test
LindaMongMCHP
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.