Update generated QIR to match the QIR adaptive spec #2990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r-updates Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
…r-updates Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
1tnguyen
reviewed
Jun 4, 2025
| if (auto *call = dyn_cast<llvm::CallBase>(&I)) { | ||
| auto name = call->getCalledFunction()->getName().str(); | ||
| if (name == "__quantum__rt__int_record_output" || | ||
| name == "__quantum__float__int_record_output") |
There was a problem hiding this comment.
Is it a typo (__quantum__float__int_record_output)?
schweitzpgi
reviewed
Jun 5, 2025
| switch (op) { | ||
| case llvm::Instruction::Select: | ||
| case llvm::Instruction::PHI: | ||
| case llvm::Instruction::Switch: |
There was a problem hiding this comment.
What about Br and CondBr?
| cudaq::opt::QIRMultipleReturnPointsFlagName, | ||
| trueValue); | ||
| } | ||
|
|
There was a problem hiding this comment.
Does any of this duplicate the functionality in the QIR verifier?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update generated QIR to match the QIR adaptive spec
Spec: https://github.com/qir-alliance/qir-spec/blob/main/specification/under_development/profiles/Adaptive_Profile.md
Updates included:
Replace use of
requiredQubitsandrequiredResultsbyrequired_num_qubitsandrequired_num_resultsUpdate module flags
Replace use of
__quantum__qis__read_result__bodyby__quantum__rt__read_result(TODO) do not add "target datalayout" and "target triple" to the module (needs investigation)