Bug: ContentTypeDescriptor.IsTypeOf() always returns true
#55
Assignees
Labels
Area: Entity
Relates to the core data data structure for modeling topic entities.
Priority: 2
Severity 1: Minor
Status 5: Complete
Task is considered complete, and ready for deployment.
Type: Bug
Behavior that is inconsistent with documented or expected behavior.
Milestone
Comments
JeremyCaney
added
Type: Bug
JeremyCaney
added a commit
that referenced
this issue
Mar 13, 2021
Went through Azure DevOps' code coverage report, and used it to patch gaps in our unit tests. There remain a lot of gaps in the `OnTopic.Data.Sql` and the `OnTopic.AspNetCore.Mvc` libraries, which will be better served by integration tests. Outside of those two libraries, we're now above 99% code coverage on the main libraries. As part of this expanded coverage, I identified and resolved a number of bugs that hadn't yet been identified, particularly around the `ITopicRepository` implementations. These include: - `SqlTopicRepository.Load()` won't delete attributes (#45) or topic references (#46) - `SqlTopicRepository.Load()` treats `Topic.References` as `!IsFullyLoaded` if there are any deleted references (#46) - `TopicRepository.Load(topic, version)` validates `version` against `DateTime.Now` not `DateTime.UtcNow` (#56) - `TopicRepository.Delete()` throws exception if the expected `ReturnCode` is missing (#48) - `TopicRepositoryDecorator.Delete()` didn't set default value for the `isRecursive` parameter (#49) - `TopicRepository.TopicRenamed` event not being raised on `Save()` (#50) - `Topic.IncomingRelationships` aren't being properly cleared by calls to `TopicReferenceCollection.Clear()` (#51) and `SetValue()` (#52) - `Topic.IsDirty()` is being set to `true` if `Topic.Parent` is set during construction, even if it's an existing entity (#53) - `ReadOnlyKeyedTopicCollection` constructor requires nullable, optional `innerCollection` parameter (#54) - `ContentTypeDescriptor.IsTypeOf()` always returns `true` and thus is non-functional (#55) - `TrackedRecord<T>` and derivative constructors don't accept a null `value`, even though the corresponding `Value` property does (#59) In addition, it identified two bugs which are scheduled for OnTopic 5.1.0, but which haven't yet been resolved: - `TopicRepository.GetAttributes()` returns mismatched attributes for both `isDirty` and `!isDirty` (#44) - `SqlTopicRepository.TopicLoaded` event is not raised with the `version` parameter where appropriate (#58)
JeremyCaney
changed the title
ContentTypeDescriptor.IsTypeOf() always returns true
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
ContentTypeDescriptor.IsTypeOf()method allows a caller to determine if a content type inherits from another content type in the topic tree. It will returntrueif an ascendantContentTypeDescriptorhas aKeymatching the suppliedcontentTypeName. If not, however, it is also defaulting totrue. This makes the method effectively useless. Fortunately, this method is rarely used—but if it is, it isn't working as expected.The text was updated successfully, but these errors were encountered: