Skip to content

Fix corrupted icons in second column #1088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 11, 2022

Conversation

among-us-official
Copy link

When using skin with a different second column icon size, all of the
icons in it would become blank.

Because m_bTwoColumns is set after AddStandardItems, it is still false
in the column break check. As a workaround, use the value it's assigned
later in InitWindowInternal instead.

Fix #980

When using skin with a different second column icon size, all of the
icons in it would become blank.

Because m_bTwoColumns is set after AddStandardItems, it is still false
in the column break check. As a workaround, use the value it's assigned
later in InitWindowInternal instead.

Fix Open-Shell#980
@AppVeyorBot
Copy link

@blackcrack
Copy link

Thank you :)))))

Copy link
Member

@Ibuprophen Ibuprophen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good. Thanks a Bunch! 👍

@Ibuprophen Ibuprophen merged commit b89aaed into Open-Shell:master Aug 11, 2022
@Ibuprophen
Copy link
Member

Thank you @among-us-official! 👍

~Ibuprophen

@CTVCAM8
Copy link

CTVCAM8 commented Aug 13, 2022

It works. Wonderful. This is similar to #561
I had mentioned it on the Classic Shell forum as well back in 2017.

Thank you, and thanks to other coders who have donated their time fixing skinned scrollbars in Win10,
adding options to float the start menu away from the desktop corner or vice versa,
and adding extra skinning options for using images for 125%, and 200% display sizes.

@Ibuprophen
Copy link
Member

Also fixes #561.

~Ibuprophen

@amymor
Copy link

amymor commented Aug 14, 2022

thank you all ❤️ , it would be greet. finally i can delete classic shell 4.3.0 😂.
but i cant download it from appveyor, can someone upload it somewhere?

@Ibuprophen
Copy link
Member

@amymor, I believe that I may have (hopefully) done it correctly this time around. 👍

https://github.com/Open-Shell/Open-Shell-Menu/releases

I'm a bit rusty regarding a push on new releases... LOL!

~Ibuprophen

@bonzibudd
Copy link
Member

Hi @among-us-official.

It seems that your update has broken the "Insert sub-items as buttons" option as seen below.
image
Here is what the right-hand items look like on 4.4.170:
image
Here's the same configuration on 4.4.179:
image
The items don't show as they should. If you could look into this, I would appreciate it. It's possible that is the option that caused the differently sized icons to be incompatible on 4.3.1 in the first place.

@among-us-official
Copy link
Author

Hey @bonzibudd, I've looked into this, it seems this behavior is caused by turning on 'No icons in second column' (Main_no_icons2 in skin file). I'm not sure if this is unintended behavior. I can add a check in the code to prevent this, but perhaps the skin itself could be updated. In any case, what I should do?

Also, the tiles are still clickable even if you can't see them. Not sure why the highlight doesn't appear.

@bonzibudd
Copy link
Member

@among-us-official I did notice this, but in 4.4.170 and older, the Sub-items option would override the setting for no icons, which is why I can have items like the shutdown button coexisting with the tiles. If there is a way you could restore this behavior, I would appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium priority Non-critical but desired fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unknown icons on right side when small
7 participants