-
Notifications
You must be signed in to change notification settings - Fork 459
Fix corrupted icons in second column #1088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
When using skin with a different second column icon size, all of the icons in it would become blank. Because m_bTwoColumns is set after AddStandardItems, it is still false in the column break check. As a workaround, use the value it's assigned later in InitWindowInternal instead. Fix Open-Shell#980
Thank you :))))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good. Thanks a Bunch! 👍
Thank you @among-us-official! 👍 ~Ibuprophen |
It works. Wonderful. This is similar to #561 Thank you, and thanks to other coders who have donated their time fixing skinned scrollbars in Win10, |
Also fixes #561. ~Ibuprophen |
thank you all ❤️ , it would be greet. finally i can delete classic shell 4.3.0 😂. |
@amymor, I believe that I may have (hopefully) done it correctly this time around. 👍 https://github.com/Open-Shell/Open-Shell-Menu/releases I'm a bit rusty regarding a push on new releases... LOL! ~Ibuprophen |
Hey @bonzibudd, I've looked into this, it seems this behavior is caused by turning on 'No icons in second column' (Main_no_icons2 in skin file). I'm not sure if this is unintended behavior. I can add a check in the code to prevent this, but perhaps the skin itself could be updated. In any case, what I should do? Also, the tiles are still clickable even if you can't see them. Not sure why the highlight doesn't appear. |
@among-us-official I did notice this, but in 4.4.170 and older, the Sub-items option would override the setting for no icons, which is why I can have items like the shutdown button coexisting with the tiles. If there is a way you could restore this behavior, I would appreciate it. |
When using skin with a different second column icon size, all of the
icons in it would become blank.
Because m_bTwoColumns is set after AddStandardItems, it is still false
in the column break check. As a workaround, use the value it's assigned
later in InitWindowInternal instead.
Fix #980