Skip to content

Add -reloadsettings command line switch #1158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2022

Conversation

ge0rdi
Copy link
Member

@ge0rdi ge0rdi commented Sep 30, 2022

It will force Open-Shell to reload settings from registry.

Fixes #1157.

It will force Open-Shell to reload settings from registry.

Fixes Open-Shell#1157.
@AppVeyorBot
Copy link

Copy link

@blackcrack blackcrack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good have add it to
the Open-Shell Almanach who i have build together
by the way.. the restart of open shell behind the installation works still not..
installed Open-Shell-Menu 4.4.179-fnksobqo
best.. and keep it up :)

@Ibuprophen , @coddec , @XenHat could you review it ?

Copy link
Member

@Ibuprophen Ibuprophen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks simple and good on my end. I'll leave it to the the rest of the team for review and approval.

~Ibuprophen

@blackcrack
Copy link

blackcrack commented Oct 4, 2022

@Ibuprophen
Hi Ibu,
hmm, you be in the Team, you should be in able to open the Green Button "Review changes" and Check the "O Approve" Option for enabling the Merging from G0erdi .. it is not to be a high complex code ;) Only approve and the Merging works, like i guess.. a Review is not manny only a text "looks good" or something... Because the Review is open and should only done.. that's all.. and G0rdie makes no "junk" like i think me ;).. so only a Approvement from You 😃
best

@Ibuprophen
Copy link
Member

@blackcrack, I do understand what you're referring to and, based upon the recent issue, I really don't want to officially "approve" anything without (at least) one of the other team members (@ge0rdi, @XenHat or @coddec) asking me to do so.

I just wanted to provide my input here for the others to take note.

~Ibuprophen

@dominichayesferen
Copy link

I can verify this patch works!

@Open-Shell Open-Shell deleted a comment from blackcrack Oct 8, 2022
@ge0rdi
Copy link
Member Author

ge0rdi commented Oct 8, 2022

@dominichayesferen
Thank you for confirmation.
Going to merge it.

@ge0rdi ge0rdi merged commit e6b33a7 into Open-Shell:master Oct 8, 2022
@ge0rdi ge0rdi deleted the reload-settings-command branch October 8, 2022 05:48
@blackcrack

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an command to reload settings from registry on-the-fly?
5 participants