Skip to content

Update Start Menu style previews. #1836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 17, 2024
Merged

Update Start Menu style previews. #1836

merged 1 commit into from
Feb 17, 2024

Conversation

Lixkote
Copy link

@Lixkote Lixkote commented Feb 9, 2024

Update the old blurry start menu previews from classic shell days to a more modern pixel-perfect ones that resemble the new default immersive skin and the previews that Windows 10 gives in settings app.
obraz
obraz

Update the old blurry start menu previews to a more modern pixel-perfect ones that resemble the new default immersive skin.
@AppVeyorBot
Copy link

@ge0rdi
Copy link
Member

ge0rdi commented Feb 10, 2024

@bonzibudd
Any thoughts on this?

@ge0rdi ge0rdi requested a review from bonzibudd February 10, 2024 11:29
@Darthagnon
Copy link

Darthagnon commented Feb 10, 2024

I vote nay; the Aero screenshots included by default beat oversimplified Metro screenshots proposed. The sort of people installing Open/Classic Shell are looking to make Win10 look like Win7, so no reason to make it look more like Win10. The previews are also not "blurry".
chrome_240210_03

Copy link
Member

@bonzibudd bonzibudd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks great 👍

@Lixkote
Copy link
Author

Lixkote commented Feb 11, 2024

I vote nay; the Aero screenshots included by default beat oversimplified Metro screenshots proposed. The sort of people installing Open/Classic Shell are looking to make Win10 look like Win7, so no reason to make it look more like Win10. The previews are also not "blurry". chrome_240210_03

I think personally, that my previews are still better than the old ones simply because;

  1. Old previews are inaccurate, the default skin is not Windows 7's aero anymore, but its the Immersive skin which IS windows 10 styled, thus my previews provide an better visual representation of the actual default theme for the end user.
  2. I feel open shell needs some modernization and improvements, and the previews were still from the classic shell's days, thus not reflecting the current features and changes.
  3. From what i've seen most people(not tech oriented people, for example teachers in my school's computer lab) that use open shell use it for just the classic layout that they are used to, they don't really care about full theming the os to look like w7, and these who do, will be tech savy enough that new previews won't be any issue for them.

@ge0rdi
Copy link
Member

ge0rdi commented Feb 17, 2024

Personally, I have no problem with existing previews, even if they are blurry and inaccurate (yup the menu looks differently by default).

But I agree that the point of these previews is to show how the menu style looks schematically.
I think it is good idea to have these previews skin-neutral (as users can use many different skins).

The sort of people installing Open/Classic Shell are looking to make Win10 look like Win7, so no reason to make it look more like Win10.

I'd say there are many reasons why people install Open-Shell.
For sure they can customize it to resemble Win7 (or whatever else they are attached to).
But that is no reason to stick to some obsolete previews in settings.

@ge0rdi ge0rdi merged commit 7e83c56 into Open-Shell:master Feb 17, 2024
@bynarie
Copy link

bynarie commented Dec 21, 2024

I like the new preview layout.. Looks more modern while still accomplishing the goal.

@Darthagnon
Copy link

Darthagnon commented Feb 9, 2025

I have used Resource Hacker to revert the preview images back to the good ones used previously, as I cannot stand the ugly new flat-design previews. I prefer a preview that actually shows what my Start menu will look like when applied, rather than some non-representative abstraction. For your convenience, please find attached:

  1. Zip of the images extracted from Open Shell v4.4.191: OpenShell good screenshot DLL images.zip
  2. Patched DLL for Open Shell v4.4.195: StartMenuDLL_v4.4.195.zip

Would you guys be ok if I open a PR to revert this unfortunate change?

Preview:

Clover_250209_214

@ge0rdi
Copy link
Member

ge0rdi commented Feb 9, 2025

Would you guys be ok if I open a PR to revert this unfortunate change?

Nope.

The change was intentional and wanted.
As explained here #2063 (comment).

Feel free to use older Open-Shell version (or just your hacked version) if that's so important for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants