Skip to content

[REQ] removing size, page and sort parameter if using x-spring-paginated option #8315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MathiasHi opened this issue Jan 4, 2021 · 5 comments

Comments

@MathiasHi
Copy link
Contributor

Is your feature request related to a problem? Please describe.

I use the feature from the #5022 Pull Request. When I use the same API generation file for some other programming language as Typescript, which doesn't have a pageable type I have to add the size, page, and sort parameter. This parameter now does also appear in the spring application which I want to automatically remove when I use the option.

Describe the solution you'd like

I want to check if there are defined size, page, and sort parameters in the generation file if the x-spring-paginated option is used. If this is the case I'll remove it in the spring application, so only the pageable type is used.

Additional context

I already have helped on #5022.
Please give me feedback so I know that it is ok to fork this project and create a new Pull request with this feature.

@amelnikoff
Copy link

Indeed. Another problem is to return Page object instead of list.

@tofi86
Copy link
Contributor

tofi86 commented Feb 28, 2022

@MathiasHi would love to see this implemented! 👍

@tofi86
Copy link
Contributor

tofi86 commented Nov 18, 2022

@amelnikoff I extracted your feature request to a separate issue #14062 and may try to find a solution for this.

@tofi86
Copy link
Contributor

tofi86 commented Nov 18, 2022

@MathiasHi @amelnikoff I submitted a PR for this at #14064

anchoret pushed a commit to akorolev-dev/openapi-generator that referenced this issue Sep 21, 2024
wing328 pushed a commit that referenced this issue Apr 23, 2025
… 'x-spring-paginated' (#8315) (#21016)

* [Java][Spring] remove 'size', 'page' and 'sort' query params if using 'x-spring-paginated' (#8315)

* Properly implement samples, fixing build issues

---------

Co-authored-by: Tobias Fischer <t.fischer@goldflam.de>
@joaquinjsb
Copy link

Hi Guys, looks like #21016 has been merged, seems like this can be closed ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants