-
-
Notifications
You must be signed in to change notification settings - Fork 7k
[fix][java]Add missing generated annotation to Authentication.mustache #21125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
please update the samples when you've time |
done, was a nightmare to checkout and build locally |
can you please share more? definitely want to improve the experience building the project locally |
On windows the code generator that generates the samples and the markdown documentation is system line break dependent, so I have 888 other pending changes with just the change from LF to CRLF. |
thanks for the feedback. it's better to use WSL to run the update command as git bash may not work in certain setup. i'll update the checklist shortly with better instruction. |
This generated interface was missing the generated annotation, so it was not excluded from static code analysis in our case.
Additionally some instances declared the redundant public modifier.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming7.x.0
minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)Technical committee
@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @martin-mfg (2023/08)