Skip to content

[fix][java]Add missing generated annotation to Authentication.mustache #21125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 25, 2025

Conversation

reitzmichnicht
Copy link
Contributor

@reitzmichnicht reitzmichnicht commented Apr 22, 2025

This generated interface was missing the generated annotation, so it was not excluded from static code analysis in our case.

Additionally some instances declared the redundant public modifier.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Technical committee

@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @martin-mfg (2023/08)

@reitzmichnicht reitzmichnicht changed the title Add missing generated annotation to Authentication.mustache [fix][java]Add missing generated annotation to Authentication.mustache Apr 22, 2025
@wing328
Copy link
Member

wing328 commented Apr 23, 2025

@reitzmichnicht
Copy link
Contributor Author

done, was a nightmare to checkout and build locally

@wing328
Copy link
Member

wing328 commented Apr 23, 2025

was a nightmare to checkout and build locally

can you please share more? definitely want to improve the experience building the project locally

@reitzmichnicht
Copy link
Contributor Author

On windows the code generator that generates the samples and the markdown documentation is system line break dependent, so I have 888 other pending changes with just the change from LF to CRLF.
I do not understand why this generation has to be performed locally and not done by the build server which is less error prone to user specific environments. My IntelliJ nearly crashed because of 80000 touched files.

@wing328
Copy link
Member

wing328 commented Apr 25, 2025

thanks for the feedback. it's better to use WSL to run the update command as git bash may not work in certain setup. i'll update the checklist shortly with better instruction.

@wing328 wing328 merged commit 27a705e into OpenAPITools:master Apr 25, 2025
122 checks passed
@wing328 wing328 added this to the 7.13.0 milestone Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants