Skip to content

Test on current stable release instead of nightly #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 10, 2022
Merged

Conversation

ChrisRackauckas
Copy link
Member

Nightly is not generally going to work with autodiff, while this was not testing on current stable release (v1.7) which is what most users are likely on. We usually prefer to test on stable + LTS.

@ChrisRackauckas
Copy link
Member Author

Also made it so it doesn't double test all versions.

Nightly is not generally going to work with autodiff, while this was not testing on current stable release (v1.7) which is what most users are likely on. We usually prefer to test on stable + LTS.
@codecov
Copy link

codecov bot commented Feb 10, 2022

Codecov Report

Merging #30 (65c7a48) into master (90516c4) will increase coverage by 0.83%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
+ Coverage   40.25%   41.09%   +0.83%     
==========================================
  Files           6        6              
  Lines          77       73       -4     
==========================================
- Hits           31       30       -1     
+ Misses         46       43       -3     
Impacted Files Coverage Δ
src/batched.jl 0.00% <0.00%> (ø)
src/subnets.jl 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90516c4...65c7a48. Read the comment docs.

@ChrisRackauckas
Copy link
Member Author

@pzimbrod I removed the unused dependencies like Revise, MAT, etc. which I assume were used in testing but aren't used in the repo.

@pzimbrod
Copy link
Contributor

@pzimbrod I removed the unused dependencies like Revise, MAT, etc. which I assume were used in testing but aren't used in the repo.

Yup, used them for testing but no need for them in the package

@ChrisRackauckas ChrisRackauckas merged commit 9b16e02 into master Feb 10, 2022
@ChrisRackauckas ChrisRackauckas deleted the CI_update branch February 10, 2022 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants