Skip to content

feat: Improvements considering validation phase #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Apr 30, 2020
Merged

Conversation

dewita
Copy link
Collaborator

@dewita dewita commented Apr 29, 2020

What's new

General

  • Change font weight of input for more lisibility.
  • Change the color and font weight of the "back" link in the headers.

Forms

  • When clicking on "commencer la sélection", the panel animates with bouncing shadow.

Bibliothèque

  • The search bar is now in the exercise panel for more visibility.

Menu

  • Remove rafters on the menu.

Filter panel

  • Add enter event when creating new favorite
  • Remove additional scrollbar by displaying all the tags in one category when clicking.

Favorite panel

  • Add more information when navigating into the favorite panel

Favorite

  • Remove constraint of at least one tag to create one favorite

Rich text editor

  • Add tab key event.
  • Reduce the gap between two paragraphs.

@dewita dewita requested a review from jy95 April 29, 2020 15:57
@jy95
Copy link
Member

jy95 commented Apr 29, 2020

@dewita I found something quite troublesome ^^

Test environnement :

frontend : jy95/sourcecode-front:3d91654b236540893edee22ce3ad54b5d161c506
api : jy95/sourcecode_api:ce0aa50cfb054d1358db971100d52c9f744b36e0

🐛 Somehow I got this :
image
This problem doesn't occurs with small description :
image

Steps to reproduce :

  • Use my docker-compose file and replace with given versions
  • Sign in with the admin account
  • Search for exercice "Infinite Streams" ( ID : 123 )
  • When you got to /administration/exercices/123 , you will see this bug

I remark that after we load another exercise with smaller description, the description of "Infinite Streams" is displayed (strange isn't ?)

@jy95
Copy link
Member

jy95 commented Apr 30, 2020

@dewita LGTM but there is another bug It seems

image

( No problem with that using the main interface : gestion/mes-favoris/creer-favori )

@jy95
Copy link
Member

jy95 commented Apr 30, 2020

The form is submitted twice on the url /exercices ( Chrome ) :

image

( Again, no problem with that using the main interface : gestion/mes-favoris/creer-favori )

@jy95
Copy link
Member

jy95 commented Apr 30, 2020

@dewita LGTM this time ;)

@dewita dewita merged commit 8b81060 into master Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants