Skip to content

Feat/mysql support #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Feat/mysql support #222

wants to merge 3 commits into from

Conversation

MiNeves00
Copy link
Collaborator

@MiNeves00 MiNeves00 commented Jun 4, 2025

LLMstudio-tracker Version 1.2.0

What was done in this PR:

  • Added support for MySQL:
    • Required putting a lenght in bytes of the String fields.
    • Converted longer String fields to Text
    • Updated initial migration to create for these fields

How it was tested:

  • Tested using core.py for: local sqlite; postgres; mysql
    • However these tests were only for a db with only llmstudio stuff. to make a full test would need to test the package (for this we need an alpha i think) with for example the chat-template. However it should work since no breaking changes should have been made.

Additional notes:

  • Any new dependencies added?
    cryptography ="^42.0.0" (needed for recent mysql packages)

@MiNeves00 MiNeves00 requested a review from diogoncalves June 4, 2025 09:29
@MiNeves00 MiNeves00 self-assigned this Jun 4, 2025
.gitignore Outdated
@@ -79,3 +79,5 @@ llmstudio/llm_engine/logs/execution_logs.jsonl
*.db
.prettierignore

# DB Docker Compose
docker-compose*.yml
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new line

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new line

removed and actually added a compose for testing the examples/core.py with mysql or with postgres tracking

chat_input = Column(String)
chat_output = Column(String)
session_id = Column(String(191))
chat_input = Column(Text)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@diogoncalves test on mdclone with postgresql and sqlite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants