Skip to content

fix: DestroyWithScene causes errors on non-authority side #3500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jun 17, 2025
Merged

fix: DestroyWithScene causes errors on non-authority side #3500

merged 12 commits into from
Jun 17, 2025

Conversation

NoelStephensUnity
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity commented Jun 13, 2025 •
edited
Loading

Description

This PR fixes the issue where enabling the NetworkObject.DestroyWithScene would cause errors on non-authority instances when loading a new scene (in single mode) or unloading the scene that the NetworkObject instance currently resides and using the distributed authority network topology.

Fix: #3144

MTTB-1384

Changelog

  • Fixed: Distributed authority related issue where enabling the NetworkObject.DestroyWithScene would cause errors when a destroying non-authority instances due to loading (single mode) or unloading scene events.

Testing and Documentation

  • Includes new integration test: NetworkObjectDestroyWithSceneTests.
  • No documentation changes or additions were necessary.

Backport

This is a v2.x distributed authority only issue.

@NoelStephensUnity NoelStephensUnity changed the base branch from release/2.4.2 to develop-2.0.0 June 17, 2025 19:12
@NoelStephensUnity
fix
1126132 
Fixing the issue where destroy with scene could cause errors on non-authority instances.
@NoelStephensUnity
style
2df0d17 
removing using directive.
@NoelStephensUnity
refactor
f705ff9 
Refactoring my approach.
@NoelStephensUnity
update
8002f26 
Adding change log entry.
@NoelStephensUnity
test
481a3d7 
Adjusting the NetworkObjectDestroyTests to be distributed authority compatible.
@NoelStephensUnity
style
875af86 
removing using directive.
@NoelStephensUnity
update
f737e0c 
Additional adjustments for this fix.
@NoelStephensUnity
test
224abb3 
The integration test for this fix with some integration test adjustments.
@NoelStephensUnity NoelStephensUnity force-pushed the fix/destroy-with-scene-errorlog-distributed-authority branch from 6db25f0 to 224abb3 Compare June 17, 2025 19:15
@NoelStephensUnity
update
16430ed 
moving changelog entry
@NoelStephensUnity NoelStephensUnity marked this pull request as ready for review June 17, 2025 19:21
@NoelStephensUnity NoelStephensUnity requested a review from a team as a code owner June 17, 2025 19:21
@NoelStephensUnity NoelStephensUnity enabled auto-merge (squash) June 17, 2025 19:37
@NoelStephensUnity NoelStephensUnity mentioned this pull request Jun 17, 2025
Closed
@NoelStephensUnity
style
517cf45 
Updating comment for spelling and readability.
Removing white space.
@NoelStephensUnity
style
f82d4f2 
removing a
@NoelStephensUnity
style
dec2e96 
removing using directive.
@NoelStephensUnity NoelStephensUnity merged commit f966e07 into develop-2.0.0 Jun 17, 2025
35 checks passed
@NoelStephensUnity NoelStephensUnity deleted the fix/destroy-with-scene-errorlog-distributed-authority branch June 17, 2025 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EmandM EmandM EmandM approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NoelStephensUnity @EmandM