Library is using Asserts without throwing a message

[jposada202020]

Library is using assert statements. It is preferable to add a customary message to inform the problem
outdated: .instead use Exceptions.

Adafruit_CircuitPython_FXAS21002C/adafruit_fxas21002c.py

Line 83 in 7b68d87

assert gyro_range in (

[dastels]

I disagree. Asserts are good for catching cases that can not sanely occur: programmer error, while exceptions are best suited to things a that go wrong unexpectedly, but for which there is often a way to deal with it: e.g. a communication problem. I.e. Exceptions can be handled, but asserts have no recourse but to cause execution to stop/fail.

In this case the assert enforces the contract of the method... gyro_range HAS to be one of those values. If it's something else, the programmer messed up.

[jposada202020]

Thanks, valid points. not arguing with that. Taking into account, that I have no problem closing this issue, what would be more helpful to the end user?
maybe and assertion with a message could work?

[dastels]

It's really a matter of accepted/encouraged style. But that's what asserts are for. Some people use them, some don't. Using an exception and not handling it does the same job, but obscures the intent.

A message is always a good idea.

[jposada202020]

Right Thanks.. 👍🏼

[tannewt]

How does one add a message to an assert in case it happens? If it's not expected to happen then I'd rather remove them. (Remember that asserts use memory.) If they may happen, then an exception with a message would make them more actionable.

[jposada202020]

Will do Thanks

[jposada202020]

Fix by #23