Closed
Description
Hi there.
I was trying to run the 'examples/midi_inoutdemo.py' script today and had a problem.
It seems the changes made by @dherrada in #33 to note_off.py - specifically changing the class variables to be preceded by an underscore (eg self.note is now self._note) mean that the demo crashes out at line 65 because 'NoteOff' has no attribute 'note'.
Why were these changes to note_off.py necessary? And is the best fix to revert the changes, add getter methods for 'note' etc, or change the example code?
I haven't managed to try it yet, but I'm a bit confused as to why this would not also cause an error when running 'tests/test_MIDI_unittests.py' since this looks like it would simulate this.
Metadata
Metadata
Assignees
Labels
No labels