Skip to content

Fix Issue #90: Remaining length issues #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 22, 2021
Merged

Fix Issue #90: Remaining length issues #91

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8f1f897
Update adafruit_minimqtt.py
Eason010212 Aug 27, 2021
3980b5a
Update adafruit_minimqtt.py
Eason010212 Aug 27, 2021
df63c8f
Update adafruit_minimqtt.py
Eason010212 Aug 28, 2021
a2032c0
Update adafruit_minimqtt.py
Eason010212 Aug 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions adafruit_minimqtt/adafruit_minimqtt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,13 @@
_default_sock = None # pylint: disable=invalid-name
_fake_context = None # pylint: disable=invalid-name

# Override default len() method
len_overrided = len
def len(object):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a more elegant way we can detect this instead of overriding the len method?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the latest commit (a2032c0) and compare it with the original version.
I removed the overloaded method and replaced it with a more polite fix (I checked the usage of all len (str) in the code and replaced them with len (bytes) if necessary to correct the calculation result of the remaining length).
Please check whether my modification is valid and correct. Thank you.

if isinstance(object, str):
return len_overrided(object.encode('utf-8'))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is the len_overrided method declared?

else:
return len_overrided(object)

class MMQTTException(Exception):
"""MiniMQTT Exception class."""
Expand Down