Fix rectangle size, add font support #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ence it as a file! (code moved from unsupported https://github.com/adafruit/micropython-adafruit-bitmap-font to here)
eighthree
reviewed
Dec 22, 2018
adafruit_framebuf.py
Outdated
| @@ -223,9 +225,81 @@ def scroll(self): | |||
| """scroll is not yet implemented""" | |||
| raise NotImplementedError() | |||
|
|
|||
| def text(self): | |||
| def text(self, string, x, y, color, *, | |||
| font_name="font5x8.bin"): | |||
| """text is not yet implemented""" | |||
There was a problem hiding this comment.
The comment for "text is not yet implemented" could be removed.
There was a problem hiding this comment.
ok fixed, please approve the PR if its good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ive joined https://github.com/adafruit/micropython-adafruit-bitmap-font into framebuf cause i feel like if you're going to draw text, you'll want lines and pixels too!
i've also fixed the ustruct thingy