Skip to content

Move shebang to the beginning of the detect script #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2022

Conversation

cdwilson
Copy link
Contributor

@cdwilson cdwilson commented Mar 5, 2022

No description provided.

@ladyada
Copy link
Member

ladyada commented Mar 5, 2022

@evaherrada this affects spdx detection filter

@cdwilson
Copy link
Contributor Author

cdwilson commented Mar 5, 2022

this affects spdx detection filter

Is this filter something specific to adafruit? The reuse addheader docs mention the following:

Shebangs are always preserved at the top of the file.

@ladyada
Copy link
Member

ladyada commented Mar 5, 2022

yah its our own regexp, no worries, just fyi to @evaherrada !

@makermelissa
Copy link
Collaborator

Should I wait on merging this until the script is updated?

@ladyada
Copy link
Member

ladyada commented Mar 7, 2022

i dont know we run spdx check on this repo, its more of a reminder to eva! cause we will bump into this again!

Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. Thanks.

@makermelissa makermelissa merged commit 4666ca2 into adafruit:main Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants