Initial support for Sifive's HiFive Unleashed #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makermelissa
requested changes
Jul 10, 2019
| @@ -78,6 +79,9 @@ def _linux_id(self): # pylint: disable=too-many-branches | |||
| if self.detector.check_dt_compatible_value("qcom,apq8016"): | |||
| return APQ8016 | |||
|
|
|||
| if self.detector.check_dt_compatible_value("fu500"): | |||
There was a problem hiding this comment.
We should probably change this to a little longer string like "sifive,fu540gsifive"
There was a problem hiding this comment.
Out of the 3 values in the proc file, only the first or third values work.
if self.detector.check_dt_compatible_value("fu500"): # Works
if self.detector.check_dt_compatible_value("sifive,fu540gsifive"): # Does not
if self.detector.check_dt_compatible_value("sifive"): # Works
if self.detector.check_dt_compatible_value("sifive,fu540gsifive,fu500"): # Does not
There was a problem hiding this comment.
What about:
if self.detector.check_dt_compatible_value("fu540gsifive"):
makermelissa
approved these changes
Jul 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Board family detection still missing. Chip and board are fine.
From test code:
('Chip id: ', 'HFU540')
('Board id: ', 'SIFIVEHFUA00')
('Sifive? ', False)
Should be true.