Skip to content

Addition of onion omega board running OpenWRT #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 3, 2020

Conversation

yeyeto2788
Copy link
Contributor

This is regarding issue #45

@yeyeto2788
Copy link
Contributor Author

I forgot to add the results of the modifications:

root@Omega-198C:/workspace/Adafruit_Python_PlatformDetect# python3
Python 3.6.10 (default, Dec 20 2019, 23:32:32) 
[GCC 7.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import adafruit_platformdetect
>>> detector = adafruit_platformdetect.Detector()
>>> detector.chip.id    
'ONION_OMEGA'
>>> detector.board.id
'ONION_OMEGA'
>>> detector.board.any_embedded_linux
True
>>> exit()

Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for submitting this. It appears the Onion Omega2 runs a MIPS32 24Kc processor according to https://en.wikipedia.org/wiki/Omega2_(computer) and the original Onion Omega runs on the Qualcomm Atheros AR9331 according to both the same page and http://onioniot.github.io/wiki/Documentation/Hardware/Omega-Hardware.html. It appears you are detecting both of the chips as "ONION_OMEGA." Since the chips are different (though possibly the same pinout), we should probably be detecting those separately. If you only have one of these boards, then please only add that board. Thank you.

@makermelissa
Copy link
Collaborator

I just noticed for both CPUs (as you posted in issues), it appears they come back as MIPS 24kc. Let's use that for the chip for both and I think that will be good.

@yeyeto2788
Copy link
Contributor Author

Hey @makermelissa I have added the changes you asked for. Now I'm using the cpu model key/attribute and looking for the MIPS 24Kc. Hope that's correct now, it actually make sense to look for that word.

I do have both boards, the only problem I'm facing is that I only have the old mini dock which is not compatible with the Omega2 so I'm waiting for the USB-TTL converter to be delivered, but the first Omega is the one I'm able to test the implementation.

root@Omega-198C:/workspace/Adafruit_Python_PlatformDetect# python3
Python 3.6.10 (default, Dec 31 2019, 14:49:13) 
[GCC 7.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import adafruit_platformdetect
>>> detector = adafruit_platformdetect.Detector()
>>> detector.chip.id
'ONION_OMEGA'
>>> detector.board.id
'ONION_OMEGA'
>>> detector.board.any_embedded_linux
True
>>> 

If there is anything else I can do, just let me know.

Regards.

@makermelissa
Copy link
Collaborator

Thanks. I actually have an Omega2 that I can use to try with.

Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like just a few small changes are required. Once that's done and passing, I'll give it a try on the Omega2.

@makermelissa
Copy link
Collaborator

I'll give this a test on the Omega2 next.

@yeyeto2788
Copy link
Contributor Author

No problem, I've tested it and in the original Omega works:

root@Omega-198C:/overlay/workspace/AdafruitPython_PlatformDetect# git pull
remote: Enumerating objects: 8, done.
remote: Counting objects: 100% (8/8), done.
remote: Compressing objects: 100% (7/7), done.
remote: Total 8 (delta 1), reused 4 (delta 1), pack-reused 0
Unpacking objects: 100% (8/8), done.
From https://github.com/yeyeto2788/Adafruit_Python_PlatformDetect
   a35117b..1819e60  master     -> origin/master
Updating a35117b..1819e60
Fast-forward
 adafruit_platformdetect/board.py | 1076 +++++++++++++++++++-------------------
 adafruit_platformdetect/chip.py  |    6 +-
 2 files changed, 541 insertions(+), 541 deletions(-)
root@Omega-198C:/overlay/workspace/AdafruitPython_PlatformDetect# python3
Python 3.6.10 (default, Dec 20 2019, 23:32:32) 
[GCC 7.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import adafruit_platformdetect
>>> detector = adafruit_platformdetect.Detector()
>>> detector.chip.id
'MIPS24KC'
>>> detector.board.id
'ONION_OMEGA'
>>> detector.board.any_embedded_linux
True
>>> 

@makermelissa
Copy link
Collaborator

It looks like the Onion Omega2 has a slightly different proc, the MIPS 24KEc, so I updated the code for that and pushed it to your repo.

@makermelissa makermelissa merged commit bf42d08 into adafruit:master Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants