Skip to content

Add platform detection for the UDOO Bolt #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 18, 2020
Merged

Add platform detection for the UDOO Bolt #80

merged 6 commits into from
May 18, 2020

Conversation

geekguy-wy
Copy link
Contributor

This is my first try at adding platform detection for the UDOO Bolt. It needs to be tested.

(UNTESTED WIP)

@makermelissa makermelissa requested a review from a team May 18, 2020 15:50
makermelissa
makermelissa reviewed May 18, 2020
View reviewed changes
Copy link
Collaborator

@makermelissa makermelissa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great so far. However I noticed you wrote the check_board_asset_tag_value() function, but it doesn't appear that you're actually using it. Did you mean to to use it in the board detection code?

@geekguy-wy
Copy link
Contributor Author

geekguy-wy commented May 18, 2020 •
edited
Loading

I am going to try the check_board_asset_tag_value() next. Detecting the chip causes the board to also be detected.

@makermelissa makermelissa merged commit a7da497 into adafruit:master May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makermelissa makermelissa makermelissa left review comments

@ladyada ladyada ladyada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@geekguy-wy @ladyada @makermelissa