Adding Tinker Board detection #84
Conversation
Adding detection for the ASUS Tinker Board SBC. SoC: Rockchip 3288 (RK3288)
|
Thanks, 2 things you may want to look at:
|
|
okay, thanks! will update. |
adding any_asus_tinker_board for embedded linux system identification
|
It looks like it just needs to be Black formatted. You should be able to install it on your computer with: |
updating chip.py and boards.py to be Black formatted
|
thanks for the info on Black formatting! i'm seeing that pylint error- going to work on it. |
fixing pylint errors
Reformatted with Black- sorry for all the back and forth, it's my first time doing something like this.
adafruit_platformdetect/board.py
Outdated
| @@ -119,6 +119,8 @@ def id(self): | |||
| board_id = self._clockwork_pi_id() | |||
| elif chip_id == chips.RK3308: | |||
| board_id = self._rock_pi_id() | |||
| elif chip_id == chips.RK3288: | |||
| board_id = boards.ASUS_TINKER_BOARD | |||
There was a problem hiding this comment.
Did you mean to use _asus_tinker_board_id here?
There was a problem hiding this comment.
i was having trouble with that earlier trying to get it to pass lint but i think it was more _asus_tinker_board_id function returning something else. it's passing now though so will commit again with that update shortly.
There was a problem hiding this comment.
Ok, sounds good. I just wanted to make sure.
There was a problem hiding this comment.
Hi, just curious if you were planning on making this change in this pull request?
Changing ASUS_TINKER_BOARD to _ASUS_TINKER_BOARD. Should be last commit, thank you for all your help and guidance!
Changed some things up to have everything match formatting for multiple boards so that more Tinker Board types can be added easily (I'm hoping to add the S after the original Tinker Board is all set)
|
i had to merge to update branches after i had made changes locally- it looks okay but if anything is funky that is probably why and i'll redo. again, i really appreciate your patience and guidance on this! |
|
Hi @BlitzCityDIY, were you planning on updating the code to use |
|
Hi @makermelissa ! I have to admit I got a little lost here. I'll work on this this afternoon |
|
Thanks. Let me know if you have any questions. |
Updating to boards._ASUS_TINKER_BOARD_IDS
|
Hi @makermelissa ! when I submitted this it didn't seem to go through the usual checks/processes. Should I try committing again or is it okay? |
|
It's ok. The reason I haven't merged it yet is because I thought you were still working on it since you haven't made use of the _asus_tinker_board_id() function. |
Changing to use function _asus_tinker_board_id() in board.py
|
thank you @makermelissa !! I learned a lot doing this. |
|
You're welcome and thank you for adding this. |
Adding detection for the ASUS Tinker Board SBC.
SoC: Rockchip 3288 (RK3288)