Skip to content

Marking peer support for NG12 #2834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
May 18, 2021
Merged

Marking peer support for NG12 #2834

merged 19 commits into from
May 18, 2021

Conversation

jamesdaniels
Copy link
Member

@jamesdaniels jamesdaniels commented May 17, 2021

Mostly just build process and testing stuff.

#2832, #2830, #2829

@google-cla google-cla bot added the cla: yes label May 17, 2021
@jamesdaniels jamesdaniels changed the title WIP support for NG12 Marking peer support for NG12 May 17, 2021
@jamesdaniels jamesdaniels merged commit e551ff7 into master May 18, 2021
@jamesdaniels jamesdaniels deleted the ng12 branch May 18, 2021 09:23
@johanchouquet
Copy link
Contributor

Hi @jamesdaniels , I saw that you commented line 18 of server.ts import 'dir-loader!./firestore-protos';.
I added this line myself to deal with the protos for firebase dependencies on the server. But with ng12 and webpack 5 under the hood, I've been struggling quite much with protos stuff. I tried to remove just like you this line with dir-loader, but I encounter other errors (also tried the externalDependencies in angular.json). But none of this works for me.

Do you have some clues on how to replace the dir-loader thing with Angular 12 which supports webpack 5 (related to Assets modules?). I don't have any webpack.config.js.

@jamesdaniels
Copy link
Member Author

Hi @jamesdaniels , I saw that you commented line 18 of server.ts import 'dir-loader!./firestore-protos';.
I added this line myself to deal with the protos for firebase dependencies on the server. But with ng12 and webpack 5 under the hood, I've been struggling quite much with protos stuff. I tried to remove just like you this line with dir-loader, but I encounter other errors (also tried the externalDependencies in angular.json). But none of this works for me.

Do you have some clues on how to replace the dir-loader thing with Angular 12 which supports webpack 5 (related to Assets modules?). I don't have any webpack.config.js.

I made an alternative now that we can't lean on dir-loader, import '@angular/fire/firestore-protos';

@johanchouquet
Copy link
Contributor

Hi @jamesdaniels,

Thanks for coming back to me. Sure thing, I'll try that. But, just to be clear, I suppose it is only in the v7 of AngularFire, right ? Or is it ported back into v6.1.5 ?

@jamesdaniels
Copy link
Member Author

@johanchouquet I did not port backwards no. One could use a similar strategy though, see my build script for its construction if your not ready for the upgrade.

@johanchouquet
Copy link
Contributor

Sure thing, I'll check it out. Thanks @jamesdaniels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants