[CKS] Create Kubernetes ISO support for ARCH optional parameter #10986
Conversation
nvazquez
requested review from
rohityadavcloud,
shwstppr,
kiranchavala,
vishesh92 and
Pearl1594
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10986 +/- ##
============================================
- Coverage 16.57% 16.57% -0.01%
Complexity 14059 14059
============================================
Files 5772 5772
Lines 512938 512938
Branches 62304 62304
============================================
- Hits 85026 85024 -2
- Misses 418431 418432 +1
- Partials 9481 9482 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| if [ -n "${8}" ]; then | ||
| ARCH="${8}" | ||
| if [ "$ARCH" != "amd64" ] && [ "$ARCH" != "arm64" ]; then | ||
| echo "ERROR: ARCH must be 'amd64' or 'arm64'. If the optional parameter ARCH is not set then 'amd64' is used." |
There was a problem hiding this comment.
In Java code/UI we've used aarch64, should that also translate to arm64 for consistency
There was a problem hiding this comment.
Thanks @shwstppr - fixed
There was a problem hiding this comment.
For sake of simplicity, check what arch type k8s uses in its urls (it that arm64 or aarch64) ? So the script can still take in aarch64 as input, but produce the output with arch-name as used by k8s urls.
|
@blueorangutan package |
|
@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
To be consistent to the systemvm template and packages, I think it would be better to use the following in the ISO name
refer to https://download.cloudstack.org/systemvm/4.20/ yes, I know some other projects use amd64/arm64 |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13684 |
|
Thanks @weizhouapache I have fixed the ISO naming @blueorangutan package |
|
@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13692 |
Co-authored-by: Wei Zhou <weizhou@apache.org>
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
|
@nvazquez can you resolve the conflicts. |
|
Thanks @sureshanaparti - conflicts fixed |
|
@blueorangutan package |
|
@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14219 |
Description
CloudStack supports Multi-Arch zones #9619 since 4.20.
This PR introduces an optional parameter ARCH for the
create-kubernetes-binaries-iso.shscript to include the corresponding arch binaries. Also, the generated ISO will include the ARCH on its nameTypes of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Tested three scenarios:
How did you try to break this feature and the system with this change?