This repository was archived by the owner on Oct 17, 2022. It is now read-only.
welcome #80
Merged
welcome #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 I noticed trailing whitespace change on line 43 or so, it is currently preventing some Travis checks from passing. Let's fix that and I'll merge it Thanks @stleon ! |
|
@nickva done |
|
@stleon Thank you. Merged to master. Verify it is on master and close the ticket when you get a a chance ( I rebased changes on top of latest master so I think it didn't auto-close on merge ) |
|
@nickva can you merge new changes? |
|
@stleon Done. Sorry for the delay. Thank you for your help! |
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new version