Skip to content

MacOSX: CMD+SHIFT-LEFT/RIGHT selects the entire line. Fixes #3238 #3239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 1, 2015
Merged

MacOSX: CMD+SHIFT-LEFT/RIGHT selects the entire line. Fixes #3238 #3239

merged 2 commits into from
Jun 1, 2015

Conversation

ffissore
Copy link
Contributor

/cc @Lauszus

@ffissore ffissore added the Component: IDE user interface The Arduino IDE's user interface label May 27, 2015
@ffissore ffissore self-assigned this May 27, 2015
@ffissore ffissore added this to the Release 1.6.5 milestone May 27, 2015
@Lauszus
Copy link
Contributor

Lauszus commented May 28, 2015

@ffissore yes that solves it, but I also think it would be a good idea to add support for CMD+SHIFT+UP/DOWN while we are at it.

@ffissore
Copy link
Contributor Author

@Lauszus what do CMD+SHIFT+UP/DOWN do?

@Lauszus
Copy link
Contributor

Lauszus commented May 29, 2015

It should select all text above and below the cursor respectively.

@ffissore
Copy link
Contributor Author

It should already work. I'll knock a colleague and steal her mac

@ffissore
Copy link
Contributor Author

Fixed. @ArduinoBot will prepare a build

@Lauszus
Copy link
Contributor

Lauszus commented May 30, 2015

Haha @ffissore it is not nice to steal ;)

Anyway it is still not working 100% correct.

I have taken a couple of screenshot in order to explain the current behaviour and what is wrong with it.

Cursor was moved to the end of the line and CMD+SHIFT+LEFT was pressed:
screen1

Then I pressed UP while still holding CMD+SHIFT, instead of continuing the selecting it starts from the cursor position instead:
screen2

This is how it should look like:
screen3

Note I got the last screenshot by manually selecting the text.

@Lauszus
Copy link
Contributor

Lauszus commented May 30, 2015

Btw is there anyway to just tell it to use the same behaviour as FN+SHIFT+ARROW, as it is working correctly?

ffissore added a commit that referenced this pull request Jun 1, 2015
MacOSX: CMD+SHIFT-LEFT/RIGHT selects the entire line. Fixes #3238
@ffissore ffissore merged commit 0956f5d into arduino:master Jun 1, 2015
@ffissore ffissore deleted the macosx-select-line branch June 1, 2015 07:02
@ffissore
Copy link
Contributor Author

ffissore commented Jun 1, 2015

Keyboard mappings are defined in https://github.com/arduino/Arduino/blob/master/app/src/processing/app/syntax/SketchTextAreaDefaultInputMap.java and superclasses. I can't spot FN: I can only see shift, alt, cmd, ctrl.
I've merged this PR because, at least, the implemented behaviour is now more similar to the desired one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: IDE user interface The Arduino IDE's user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants