Linux build: remove symlinks only if they exist #8781
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since the user will probably still need superuser privilages later, maybe it's also a good idea to use ln -s foo bar || sudo ln -s foo barinstead of just So it will ask the user for sudo password only if needed. |
|
@MrMebelMan thanks for the PR! I'm merging it right now; about the second part, it would complicate the script a bit but could be a good idea for systems lacking |
|
Thanks 🙏 |
|
I had this error, how to delete the file?
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The message
"Removing symlink failed. Hope that's OK. If not then rerun as root with sudo."appears even when there's no symlink (for example, when installing for the first time). I don't think that a user should be adviced to run it as root in this case.