Fixed issue #25. Possible corruption in attachInterrupt. #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digitalPinToInterrupt may return NOT_AN_INTERRUPT if an invalid pin given. attachInterrupt and detachInterrupt need to check for this or they risk corrupting memory just before intFunc[]. Please enter the commit message for your changes. Lines starting
|
I noticed an issue with this pull request...maybe no fix is necessary. See my comments in the originating issue: |
|
I think, due to the ongoing discussions in #25 that I'm going to discontinue this pull request as it is not quite correct. Yet. There's still more work to be done here on the basis of signed and unsigned 8 bit ints being passed around between I'll be back! :-) Cheers, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request created as requested for Issue #25:
digitalPinToInterrupt()may returnNOT_AN_INTERRUPTif an invalid pin given.attachInterrupt()anddetachInterrupt()both need to check for this value or they riskcorrupting memory just before
intFunc[]. Effectively corruptingintFunc[-1].