Skip to content

improv adopt logging best practices #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Apr 24, 2020
Merged
Show file tree
Hide file tree
Changes from 16 commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
e1ee083
fix: set NullHandler for package logger
heitorlessa Apr 21, 2020
976144d
improv: remove root logger logic, lib
heitorlessa Apr 21, 2020
ad408cd
fix: update exception type
heitorlessa Apr 21, 2020
8978a2d
improv: propagate log level if set, null otherwise
heitorlessa Apr 21, 2020
fa2fd0e
fix: explicit wins over env var
heitorlessa Apr 21, 2020
96c70d9
chore: fix test naming
heitorlessa Apr 21, 2020
192047e
fix: exception logging
heitorlessa Apr 21, 2020
ed547be
improv: shorten log location
heitorlessa Apr 22, 2020
ea1a742
feat: add Logger class wrapper
heitorlessa Apr 22, 2020
fd9186b
improv: add deprecation warning
heitorlessa Apr 22, 2020
a60ad0e
BREAKING CHANGE: logger_setup, inject_lambda_ctx
heitorlessa Apr 22, 2020
9be3735
improv: update tests
heitorlessa Apr 22, 2020
4467cf6
improv: cover duplicated keys edge case
heitorlessa Apr 23, 2020
220916b
improv: cover debug package logging
heitorlessa Apr 23, 2020
3cc398e
improv: more coverage, linting
heitorlessa Apr 23, 2020
447dc2b
improv: complete coverage, fix dead code
heitorlessa Apr 23, 2020
9dc2c00
docs: update readme to reflect changes
heitorlessa Apr 23, 2020
0e8dd84
fix: address jacob's code review feedback
heitorlessa Apr 24, 2020
802f181
chore: linting
heitorlessa Apr 24, 2020
9392afb
fix: metric spillover at 100, not 101
heitorlessa Apr 24, 2020
fd780be
fix: trace auto-disable, doc edge cases
heitorlessa Apr 24, 2020
bb1faf6
chore: linting
heitorlessa Apr 24, 2020
83e58fa
chore: 0.8.0 version bump
heitorlessa Apr 24, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions python/aws_lambda_powertools/__init__.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# -*- coding: utf-8 -*-

"""Top-level package for Lambda Python Powertools."""
import logging

__author__ = """Amazon Web Services"""

logger = logging.getLogger("aws_lambda_powertools")
logger.addHandler(logging.NullHandler())
4 changes: 2 additions & 2 deletions python/aws_lambda_powertools/logging/__init__.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
"""Logging utility
"""
from ..helper.models import MetricUnit
from .logger import log_metric, logger_inject_lambda_context, logger_setup
from .logger import Logger, log_metric, logger_inject_lambda_context, logger_setup

__all__ = ["logger_setup", "logger_inject_lambda_context", "log_metric", "MetricUnit"]
__all__ = ["logger_setup", "logger_inject_lambda_context", "log_metric", "MetricUnit", "Logger"]
98 changes: 0 additions & 98 deletions python/aws_lambda_powertools/logging/aws_lambda_logging.py

This file was deleted.

Loading