Skip to content

feat(eks-v2-alpha): adding takeOwnership option to HelmChart construct #34617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wafuwafu13
Copy link
Contributor

Issue # (if applicable)

Closes #32918

Reason for this change

Fulfilling the linked issue, this adds the new functionality flag of --take-ownership of Helm v3.17.0 to the HelmChart
custom resource.

Description of changes

  • Adds a new TakeOwnership payload parameter to the KubectlHandler custom resource function
  • Uses that payload to add the --take-ownership flag in the helm call in the custom resource function
  • Adds takeOwnership as an optional property to the HelmChart Construct
  • All default parameters are set to false to keep backward compatibility

Describe any new or updated permissions being added

None

Description of how you validated changes

Pass integ/unit tests

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team June 3, 2025 15:26
@github-actions github-actions bot added admired-contributor [Pilot] contributed between 13-24 PRs to the CDK effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 labels Jun 3, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: b429b18
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@wafuwafu13 wafuwafu13 changed the title feat(aws-eks-v2-alpha): adding takeOwnership option to HelmChart construct feat(eks-v2-alpha): adding takeOwnership option to HelmChart construct Jun 3, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review June 3, 2025 20:41

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admired-contributor [Pilot] contributed between 13-24 PRs to the CDK effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(aws-eks): Support --take-ownership flag in new helm version
2 participants