Skip to content

Failed creation of default mqtt client #582

Closed
@grofonn

Description

@grofonn

Describe the bug

new_default_builder function in mqtt_client_builder.py (awsiot) doesn't pass kwargs argument as expected.
It calles _builder function with kwargs as a single argument and not as a dictionary (**kwargs), which fails the creation of a mqtt client.
This seems to be the exact same problem that was reported for mqtt_connection_builder in #340 and solved in #341

Expected Behavior

Pass kwargs as a dictionary (**kwargs)

Current Behavior

Pass kwargs as a single argument

Reproduction Steps

    client = mqtt5_client_builder.new_default_builder(
        endpoint=endpoint,
        port=port,
        client_id=client_id,
        username=user,
        password=password,
        clean_session=False,
        keep_alive_secs=30,
        on_connection_interrupted=self.on_connection_interrupted,
        on_connection_resumed=self.on_connection_resumed,
        on_connection_success=self.on_connect,
        on_connection_failure=self.on_connection_failure,
        on_connection_closed=self.on_disconnect)

Possible Solution

Fix new_default_builder function' calls (pass **kwargs instead of kwargs=kwargs)

Additional Information/Context

No response

SDK version used

v2

Environment details (OS name and version, etc.)

Windows 10

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugThis issue is a bug.p2This is a standard priority issuepending-releaseThis issue will be fixed by an approved PR that hasn't been released yet.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions