Request-response MQTT service clients #619
Conversation
|
Trivial: Some explanation of what this PR is adding/doing to the summary and maybe a more descriptive title for the PR. |
| @@ -0,0 +1,84 @@ | |||
| # Jobs | |||
There was a problem hiding this comment.
Trivial: May not be worthwhile but maybe we could add a comment at the start of the deprecated sample .md files that state this sample is deprecated with a link to the current service client outside of the deprecated folder. Might not be worth the trouble though since to see this, someone would have to come looking specifically in the deprecated folder....
On a side note, should we simply remove these from existence since they're just samples that we don't want anyone using?
|
|
||
| def handle_get(context : SampleContext): | ||
| request = iotshadow.GetShadowRequest(thing_name = context.thing) | ||
| response = context.shadow_client.get_shadow(request).result() |
There was a problem hiding this comment.
debatable: In all the sandbox samples, rejected requests end up being caught by the try block in main where the input is being handled. I think for the sake of clarity to the customer and showing how a rejected response can be handled we should handle the exception explicitly, per helper function. Or at least in some way where we grab and print out the elements of a rejected request. e.g. the message, error code, timestamp, etc.
There was a problem hiding this comment.
I feel like going in this direction complicates the sample for not much value.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
bretambrose
changed the title
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.