Link errors

[Bu11etmagnet]

After pulling

From https://github.com/awslabs/aws-sdk-cpp
07987db..ea9ff52 master -> origin/master

• [new tag] 0.10.4 -> 0.10.4
• [new tag] 0.10.3 -> 0.10.3

build fails with

[151/159] Linking CXX executable aws-cpp-sdk-cognitoidentity-integration-tests/runCognitoIntegrationTests
FAILED: : && /usr/local/bin/clang++   -Wall -Werror -pedantic -Wextra -Wno-unused-private-field -fno-exceptions   aws-cpp-sdk-cognitoidentity-integration-tests/CMakeFiles/runCognitoIntegrationTests.dir/RunTests.cpp.o aws-cpp-sdk-cognitoidentity-integration-tests/CMakeFiles/runCognitoIntegrationTests.dir/IdentityPoolOperationTest.cpp.o  -o aws-cpp-sdk-cognitoidentity-integration-tests/runCognitoIntegrationTests  -rdynamic aws-cpp-sdk-access-management/libaws-cpp-sdk-access-management.so aws-cpp-sdk-iam/libaws-cpp-sdk-iam.so testing-resources/libtesting-resources.so aws-cpp-sdk-cognito-identity/libaws-cpp-sdk-cognito-identity.so aws-cpp-sdk-core/libaws-cpp-sdk-core.so -lpthread -lssl -lcrypto -lz -lcurl -Wl,-rpath,~/workspace/aws-sdk-cpp/_build_clang_custommem/aws-cpp-sdk-access-management:~/workspace/aws-sdk-cpp/_build_clang_custommem/aws-cpp-sdk-iam:~/workspace/aws-sdk-cpp/_build_clang_custommem/testing-resources:~/workspace/aws-sdk-cpp/_build_clang_custommem/aws-cpp-sdk-cognito-identity:~/workspace/aws-sdk-cpp/_build_clang_custommem/aws-cpp-sdk-core && :
aws-cpp-sdk-core/libaws-cpp-sdk-core.so: undefined reference to `Aws::Utils::Threading::ThreadTask::~ThreadTask()'
aws-cpp-sdk-core/libaws-cpp-sdk-core.so: undefined reference to `Aws::Utils::Threading::ThreadTask::ThreadTask(Aws::Utils::Threading::PooledThreadExecutor&)'
aws-cpp-sdk-core/libaws-cpp-sdk-core.so: undefined reference to `Aws::Utils::Threading::ThreadTask::StopProcessingWork()'

This is with clang 3.9.0 (trunk 264852) on Ubuntu 14.04; same error with GCC 5.3.0

[JonathanHenson]

Did you perform a clean build? I'm curious simply because I've built this on Clang and GCC fine (albeit on earlier versions) fine.

[Bu11etmagnet]

No, it was an incremental build. But I'd rather not go through a full build every time I do a 'git pull'

[Bu11etmagnet]

I did a 'ninja clean' and the error came back at the next build.

[Bu11etmagnet]

'ninja rebuild_cache' seems to be the solution.

[JonathanHenson]

I just ran a gcc 5.2.1 build on my ubuntu box. Everything looks fine. You won't have to do this every time, the problem seems to be that your build cached aws-cpp-sdk-core.so which didn't have the new symbols for the thread pool executor we added and for some reason your build didn't build that latest version of Executor.cpp. I'm not sure what the solution for us to not break your build if it doesn't rebuild the core library is since that would mean us never adding a new symbol to core.

Please reopen if you still have issues.

[Bu11etmagnet]

What do you mean by "[my] build cached aws-cpp-sdk-core.so" ? It's a straight ninja build generated by CMake.
At least there's a known workaround in case it appears again.

[Bu11etmagnet]

This appeared again after pulling:
From https://github.com/awslabs/aws-sdk-cpp
d5f7625..050fae5 master -> origin/master

FAILED: : && /usr/local/bin/clang++   -Wall -Werror -pedantic -Wextra -Wno-unused-private-field -fno-exceptions -g   aws-cpp-sdk-s3-integration-tests/CMakeFiles/runS3IntegrationTests.dir/BucketAndObjectOperationTest.cpp.o aws-cpp-sdk-s3-integration-tests/CMakeFiles/runS3IntegrationTests.dir/RunTests.cpp.o  -o aws-cpp-sdk-s3-integration-tests/runS3IntegrationTests  -rdynamic aws-cpp-sdk-s3/libaws-cpp-sdk-s3.so testing-resources/libtesting-resources.so aws-cpp-sdk-core/libaws-cpp-sdk-core.so -lpthread -lssl -lcrypto -lz -lcurl -Wl,-rpath,~/workspace/aws-sdk-cpp/_build_clang_nocustommem/aws-cpp-sdk-s3:~/workspace/aws-sdk-cpp/_build_clang_nocustommem/testing-resources:~/workspace/aws-sdk-cpp/_build_clang_nocustommem/aws-cpp-sdk-core && :
aws-cpp-sdk-s3/libaws-cpp-sdk-s3.so: undefined reference to `Aws::S3::Model::GetBucketAccelerateConfigurationResult::GetBucketAccelerateConfigurationResult()'
aws-cpp-sdk-s3/libaws-cpp-sdk-s3.so: undefined reference to `vtable for Aws::S3::Model::PutBucketAccelerateConfigurationRequest'
aws-cpp-sdk-s3/libaws-cpp-sdk-s3.so: undefined reference to `vtable for Aws::S3::Model::GetBucketAccelerateConfigurationRequest'
aws-cpp-sdk-s3/libaws-cpp-sdk-s3.so: undefined reference to `Aws::S3::Model::GetBucketAccelerateConfigurationResult::GetBucketAccelerateConfigurationResult(Aws::AmazonWebServiceResult<Aws::Utils::Xml::XmlDocument> const&)'
clang-3.6: error: linker command failed with exit code 1 (use -v to see invocation)
FAILED: : && /usr/local/bin/clang++   -Wall -Werror -pedantic -Wextra -Wno-unused-private-field -fno-exceptions -g   aws-cpp-sdk-lambda-integration-tests/CMakeFiles/runLambdaIntegrationTests.dir/FunctionTest.cpp.o aws-cpp-sdk-lambda-integration-tests/CMakeFiles/runLambdaIntegrationTests.dir/RunTests.cpp.o  -o aws-cpp-sdk-lambda-integration-tests/runLambdaIntegrationTests  -rdynamic aws-cpp-sdk-kinesis/libaws-cpp-sdk-kinesis.so aws-cpp-sdk-lambda/libaws-cpp-sdk-lambda.so aws-cpp-sdk-access-management/libaws-cpp-sdk-access-management.so aws-cpp-sdk-iam/libaws-cpp-sdk-iam.so testing-resources/libtesting-resources.so aws-cpp-sdk-cognito-identity/libaws-cpp-sdk-cognito-identity.so aws-cpp-sdk-core/libaws-cpp-sdk-core.so -lpthread -lssl -lcrypto -lz -lcurl -Wl,-rpath,~/workspace/aws-sdk-cpp/_build_clang_nocustommem/aws-cpp-sdk-kinesis:~/workspace/aws-sdk-cpp/_build_clang_nocustommem/aws-cpp-sdk-lambda:~/workspace/aws-sdk-cpp/_build_clang_nocustommem/aws-cpp-sdk-access-management:~/workspace/aws-sdk-cpp/_build_clang_nocustommem/aws-cpp-sdk-iam:~/workspace/aws-sdk-cpp/_build_clang_nocustommem/testing-resources:~/workspace/aws-sdk-cpp/_build_clang_nocustommem/aws-cpp-sdk-cognito-identity:~/workspace/aws-sdk-cpp/_build_clang_nocustommem/aws-cpp-sdk-core && :
aws-cpp-sdk-kinesis/libaws-cpp-sdk-kinesis.so: undefined reference to `Aws::Kinesis::Model::EnhancedMetrics::Jsonize() const'
aws-cpp-sdk-kinesis/libaws-cpp-sdk-kinesis.so: undefined reference to `Aws::Kinesis::Model::DisableEnhancedMonitoringResult::DisableEnhancedMonitoringResult(Aws::AmazonWebServiceResult<Aws::Utils::Json::JsonValue> const&)'
aws-cpp-sdk-kinesis/libaws-cpp-sdk-kinesis.so: undefined reference to `vtable for Aws::Kinesis::Model::EnableEnhancedMonitoringRequest'
aws-cpp-sdk-kinesis/libaws-cpp-sdk-kinesis.so: undefined reference to `vtable for Aws::Kinesis::Model::DisableEnhancedMonitoringRequest'
aws-cpp-sdk-kinesis/libaws-cpp-sdk-kinesis.so: undefined reference to `Aws::Kinesis::Model::DisableEnhancedMonitoringResult::DisableEnhancedMonitoringResult()'
aws-cpp-sdk-kinesis/libaws-cpp-sdk-kinesis.so: undefined reference to `Aws::Kinesis::Model::EnableEnhancedMonitoringResult::EnableEnhancedMonitoringResult()'
aws-cpp-sdk-kinesis/libaws-cpp-sdk-kinesis.so: undefined reference to `Aws::Kinesis::Model::EnableEnhancedMonitoringResult::EnableEnhancedMonitoringResult(Aws::AmazonWebServiceResult<Aws::Utils::Json::JsonValue> const&)'
aws-cpp-sdk-kinesis/libaws-cpp-sdk-kinesis.so: undefined reference to `Aws::Kinesis::Model::EnhancedMetrics::EnhancedMetrics(Aws::Utils::Json::JsonValue const&)'
clang-3.6: error: linker command failed with exit code 1 (use -v to see invocation)

'ninja rebuild_cache' fixed it again.

Since ninja knows about CMake, the equivalent of 'ninja rebuild_cache' should have happened automagically, so it seems a dependency is missing somewhere. I vaguely recall seeing CMake being re-run after a pull of aws-sdk-cpp (although it might have been with -G "Unix Makefiles" instead of -G "Ninja").

This is nasty because the problem might be in:

1. CMakeLists.txt in aws-sdk-cpp
2. CMake not generating the best build.ninja
3. ninja not deducing the need to re-run CMake