Skip to content

Canary using invalid metric value #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 16, 2022
Merged

Conversation

markkuhn
Copy link
Contributor

Description of changes:
Canary is throwing errors due to its use of an invalid metric value.
This value would start as None until assigned. It has been changed to initialize to 0.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@markkuhn markkuhn self-assigned this Sep 16, 2022
@markkuhn markkuhn added the bug Something isn't working label Sep 16, 2022
@markkuhn markkuhn changed the title Canary fix Canary using invalid metric value Sep 16, 2022
Copy link
Member

@gordonpn gordonpn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😂

@markkuhn markkuhn merged commit 2e6f7ea into awslabs:master Sep 16, 2022
@markkuhn markkuhn deleted the canary-fix branch September 16, 2022 17:55
@mrT23
Copy link

mrT23 commented Mar 31, 2025

@CodiumAI-Agent /review

@CodiumAI-Agent
Copy link

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Initialization Change

The change from initializing the variable with None to 0 should be double-checked to ensure that all consuming logic can handle a numeric zero correctly, and that no unintended side effects occur from this type change.

duration = 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants