Skip to content

Run clippy on all targets #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 17, 2025
Merged

Run clippy on all targets #312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1b7efc0
Run clippy on all targets
dani-garcia Jun 16, 2025
939906b
Add workflow permissions
dani-garcia Jun 16, 2025
60d319b
Let's try it
dani-garcia Jun 16, 2025
9012a54
It works, revert the test
dani-garcia Jun 16, 2025
e30c76c
Merge branch 'main' into ps/check-all-targets
dani-garcia Jun 16, 2025
ff78996
Merge branch 'main' into ps/check-all-targets
dani-garcia Jun 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ on:
branches: ["main"]
pull_request:

permissions: {}

env:
CARGO_TERM_COLOR: always

Expand All @@ -15,6 +17,9 @@ jobs:

runs-on: ubuntu-24.04

permissions:
contents: read

steps:
- name: Checkout
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
Expand Down Expand Up @@ -54,7 +59,7 @@ jobs:
run: cargo install clippy-sarif sarif-fmt --locked --git https://github.com/psastras/sarif-rs.git --rev 11c33a53f6ffeaed736856b86fb6b7b09fabdfd8

- name: Cargo clippy-sarif
run: cargo clippy --all-features --tests --message-format=json |
run: cargo clippy --all-features --all-targets --message-format=json |
clippy-sarif | tee clippy_result.sarif | sarif-fmt
env:
RUSTFLAGS: "-D warnings"
Expand All @@ -70,7 +75,7 @@ jobs:
# status code of the command is caught and reported as failed in GitHub.
# This should be cached from the previous step and should be fast.
- name: Cargo clippy
run: cargo clippy --all-features --tests
run: cargo clippy --all-features --all-targets
env:
RUSTFLAGS: "-D warnings"

Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ export RUSTFLAGS="-D warnings"

cargo +nightly fmt --check
cargo +nightly udeps --workspace --all-features
cargo clippy --all-features --tests
cargo clippy --all-features --all-targets
cargo sort --workspace --check
npm run lint
```
Expand Down