Client mode: LDAP user_id bug fix #148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #148 +/- ##
=======================================
Coverage 99.77% 99.77%
=======================================
Files 34 34
Lines 3091 3101 +10
=======================================
+ Hits 3084 3094 +10
Misses 7 7
|
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, the login passed to the Nextcloud class was taken as the user name.
If a backend other than the Database is used, these two values do not match each other, that is, the login can be:
"milena.kvitkova@domain.com", and the user ID for making API requests will be: "milena"
Note: This bug does not apply to the NextcloudApp class, because there the AppAPI transmits the user ID, and not the user login - this only affects use as a client.