Guidelines: translations #153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonaldKellett
requested changes
Nov 3, 2020
Co-authored-by: Donald Sebastian Leung <donaldsebleung@gmail.com>
|
Let's discuss your question here: #154 |
kazk
reviewed
Nov 3, 2020
Co-authored-by: kazk <kazk.dev@gmail.com>
DonaldKellett
requested changes
Nov 4, 2020
Co-authored-by: Donald Sebastian Leung <donaldsebleung@gmail.com>
DonaldKellett
requested changes
Nov 4, 2020
Co-authored-by: Donald Sebastian Leung <donaldsebleung@gmail.com>
DonaldKellett
approved these changes
Nov 4, 2020
DonaldKellett
requested changes
Nov 5, 2020
Co-authored-by: Donald Sebastian Leung <donaldsebleung@gmail.com>
DonaldKellett
approved these changes
Nov 5, 2020
DonaldKellett
approved these changes
Nov 8, 2020
DonaldKellett
approved these changes
Nov 8, 2020
|
Just like #162 , not much going on here. Good to go? |
ggorlen
approved these changes
Nov 9, 2020
|
I don't like cross reviewing, so I'll do it after the last suggestions have been examined... x) (same for the preloaded PR) |
ggorlen
approved these changes
Nov 9, 2020
DonaldKellett
approved these changes
Nov 10, 2020
DonaldKellett
approved these changes
Nov 11, 2020
Co-authored-by: Blind4Basics <32236948+Blind4Basics@users.noreply.github.com>
DonaldKellett
requested changes
Nov 11, 2020
Co-authored-by: Donald Sebastian Leung <donaldsebleung@gmail.com>
DonaldKellett
approved these changes
Nov 11, 2020
|
It's gotten quiet here, so... merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like this to be a set of official quality guidelines which reviewers could use to determine if a Translation is of sufficient quality to be approved.
Any remarks or reviews are welcome!
Discussion: #134
Deploy preview: here