Skip to content

feat: add a simple NN trainer #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 24, 2022
Merged

feat: add a simple NN trainer #8

merged 9 commits into from
Jun 24, 2022

Conversation

kkweon
Copy link
Member

@kkweon kkweon commented Jun 22, 2022 •
edited
Loading

  • 간단한 학습 코드 예시 생성
  • 이후 할 일
    • github.com/smilegate-ai/korean_unsmile_dataset 라이센스 표시
    • 모델 튜닝
    • 모델 저장 및 저장소로 푸시
    • 익스텐션에서 모델 불러오는 코드 작성

@deep-diver
Copy link
Member

deep-diver commented Jun 23, 2022 •
edited
Loading

요 코드는 어떻게 실행해볼 수 있을까요??

trainer 디렉터리에서 npm install로 패키지 설치 후 npx ts-node trainer.js 같은식인가요?

그러면 이거를 package.json 의 scripts에 포함시키면 어떨까용?

@deep-diver
Copy link
Member

fitDataset 호출시 별도로 검증용 데이터셋을 구성해서 넘겨주는게 좋지 않을까요?

@kkweon
Copy link
Member Author

kkweon commented Jun 23, 2022

요 코드는 어떻게 실행해볼 수 있을까요??

trainer 디렉터리에서 npm install로 패키지 설치 후 npx ts-node trainer.js 같은식인가요?

그러면 이거를 package.json 의 scripts에 포함시키면 어떨까용?

good idea 임다.

fitDataset 호출시 별도로 검증용 데이터셋을 구성해서 넘겨주는게 좋지 않을까요?

good idea 임다.

@deep-diver deep-diver self-requested a review June 23, 2022 23:52
@deep-diver
Copy link
Member

@kkweon

제가 대충 추가해 보았습니다. 리뷰해주시면 감사하겠습니당

kkweon
kkweon commented Jun 24, 2022
View reviewed changes
Copy link
Member Author

@kkweon kkweon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

deep-diver and others added 5 commits June 24, 2022 09:23
@deep-diver @kkweon
Update trainer/trainer.ts
8fe5880 
Co-authored-by: Mo Kweon <kkweon@gmail.com>
@deep-diver @kkweon
Update trainer/trainer.ts
aac9c80 
Co-authored-by: Mo Kweon <kkweon@gmail.com>
@deep-diver @kkweon
Update trainer/trainer.ts
252c51e 
Co-authored-by: Mo Kweon <kkweon@gmail.com>
@deep-diver @kkweon
Update trainer/package.json
12e10c2 
Co-authored-by: Mo Kweon <kkweon@gmail.com>
@deep-diver
remove unnecessary filter in tf.data
93b3996
kkweon
kkweon commented Jun 24, 2022
View reviewed changes
Copy link
Member Author

@kkweon kkweon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

deep-diver
deep-diver approved these changes Jun 24, 2022
View reviewed changes
Copy link
Member

@deep-diver deep-diver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one!

@kkweon kkweon merged commit e0b785c into main Jun 24, 2022
@kkweon kkweon deleted the feat/trainer branch June 24, 2022 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deep-diver deep-diver deep-diver approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kkweon @deep-diver