merge PR 477 from 1.0 #508
Conversation
| @@ -138,7 +138,7 @@ export class FundingRequest | |||
| method: 'propose', | |||
| args: [ | |||
| options.beneficiary, | |||
| options.amount.toNumber(), | |||
| options.amount.toString(), | |||
There was a problem hiding this comment.
this plugin is not supported in alchemy yet. so why update that ?
@jellegerbrandy is that needed for Common ?
There was a problem hiding this comment.
the change is needed in any case. without it we would have a bug by casting a BN to a number, assuming the BN in this case can easily overflow a number.
However, just to note: I don't think this change was absolutely needed for this particular PR.
There was a problem hiding this comment.
Yeah, this is good 👍
| @@ -43,7 +44,7 @@ export class GenericPlugin extends ProposalPlugin< | |||
| IGenericPluginState, | |||
| IGenericPluginProposalState, | |||
| IProposalCreateOptionsGS | |||
| > { | |||
| > { | |||
There was a problem hiding this comment.
why additiional space is here ?
There was a problem hiding this comment.
This was generated by my editor. I'm not sure what rules it is following, but the change makes sense by aligning the bracket with the lines above. Looks clean and harmless enough to me.
Merges #477 from 1.0