Skip to content

fix(carbon): Fix console error in search component for placeholder prop #1054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kavyanekkalapu
Copy link
Contributor

@kavyanekkalapu kavyanekkalapu commented May 17, 2021

Search component props has renamed in carbon components, so we are getting console error.

Screen Shot 2021-05-14 at 11 16 15 AM

@codecov
Copy link

codecov bot commented May 17, 2021

Codecov Report

Merging #1054 (703cec8) into master (82579f0) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1054   +/-   ##
=======================================
  Coverage   85.31%   85.31%           
=======================================
  Files         202      202           
  Lines        3391     3391           
  Branches     1168     1168           
=======================================
  Hits         2893     2893           
  Misses        498      498           
Impacted Files Coverage Δ
...nt-mapper/src/dual-list-select/dual-list-select.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82579f0...703cec8. Read the comment docs.

@rvsia
Copy link
Contributor

rvsia commented May 17, 2021

@kavyanekkalapu please update the commit message to match the pullrequest title (to trigger a release)

@kavyanekkalapu kavyanekkalapu force-pushed the carbon_console_error_duallist branch from 2f374fe to 703cec8 Compare May 17, 2021 15:47
@rvsia rvsia merged commit d2a8f8e into data-driven-forms:master May 17, 2021
@rvsia rvsia added backport-v2 PRs that needed to be backported to v2 bug Something isn't working Carbon PRs/Issues for IBM's Carbon design system labels May 17, 2021
@rvsia
Copy link
Contributor

rvsia commented May 17, 2021

@kavyanekkalapu thanks! 🏆 Do you want to also backport it to V2? If so, could you please open the same PR just to “v2” branch?

@Hyperkid123
Copy link
Member

🎉 This PR is included in version 3.6.3 🎉

The release is available on

Demo can be found here!

@kavyanekkalapu
Copy link
Contributor Author

@kavyanekkalapu thanks! 🏆 Do you want to also backport it to V2? If so, could you please open the same PR just to “v2” branch?

@rvsia Yes, will do. Thanks for reviewing and merging it already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v2 PRs that needed to be backported to v2 bug Something isn't working Carbon PRs/Issues for IBM's Carbon design system released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants