feat(renderer): enable condition set as a function #1331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

Hyperkid123 merged 2 commits into data-driven-forms:master from JuliePrazakova:feature

Oct 18, 2022

Collaborator

JuliePrazakova commented Oct 4, 2022 •

edited

Loading

Fixes #1326

Checklist: (please see documentation page for more information)

Yarn build passes
Yarn lint passes
Yarn test passes
Test coverage for new code (if applicable)
Documentation update (if applicable)
Correct commit message
- format fix|feat({scope}): {description}
- i.e. fix(pf3): wizard correctly handles next button
- fix will release a new _._.X version
- feat will release a new _.X._ version (use when you introduce new features)
  - we want to avoid any breaking changes, please contact us, if there is no way how to avoid them
- scope: package
- if you update the documentation or tests, do not use this format
  - i.e. Fix button on documenation example page


          fix renderer dev server

a947680

DataDrivenFormsBot commented Oct 4, 2022 •

edited

Loading

A new version (feat) will be released: v3.19.0 [DataDrivenFormsBot]

codecov bot commented Oct 4, 2022 •

edited

Loading

Codecov Report

Merging #1331 (14de368) into master (bc00ae0) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1331      +/-   ##
==========================================
+ Coverage   95.09%   95.11%   +0.01%     
==========================================
  Files         209      209              
  Lines        3627     3641      +14     
  Branches     1265     1270       +5     
==========================================
+ Hits         3449     3463      +14     
  Misses        178      178

Impacted Files	Coverage Δ
...ges/react-form-renderer/src/condition/condition.js	`98.27% <100.00%> (+0.54%)`	⬆️
...fault-schema-validator/default-schema-validator.js	`99.15% <100.00%> (ø)`

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

JuliePrazakova force-pushed the feature branch from 1f993da to 6d7bac3 Compare

October 11, 2022 09:25

JuliePrazakova requested review from Hyperkid123 and rvsia

October 11, 2022 09:29

JuliePrazakova added the renderer label

JuliePrazakova marked this pull request as ready for review

October 11, 2022 09:29

JuliePrazakova changed the title ~~fix renderer dev server~~ feat(renderer): enable condition set as a function

rvsia reviewed

View reviewed changes

Contributor

rvsia left a comment

Thank you, it looks great!

Checked only the code so far, found some nitpicks.

Could you please also update the documentation to introduce this new feature?

packages/react-form-renderer/src/condition/condition.js Outdated

               import PropTypes from 'prop-types';
               import isEqual from 'lodash/isEqual';
               import useFormApi from '../use-form-api';
               import parseCondition from '../parse-condition';
+              function setterValueCheck(setterValue) {

Contributor

rvsia Oct 12, 2022

Could you please use arrow function notation here to keep the consistency?

packages/react-form-renderer/src/condition/condition.js Outdated

@@ @@ -42,6 +52,14 @@ const Condition = React.memo( @@
                     }
                   }, [dirty]);
+                  const x = useCallback(

Contributor

rvsia Oct 12, 2022

x is kinda a mysterious name 😵‍💫

packages/react-form-renderer/src/condition/condition.js Outdated

+                        formOptions.change(name, value);
+                      });
+                    },
+                    [formOptions.change]

Contributor

rvsia Oct 12, 2022

formOptions.change will be always the same, so no need to check it

packages/react-form-renderer/src/condition/condition.js Show resolved Hide resolved

packages/react-form-renderer/src/tests/form-renderer/condition.test.js Outdated

@@ @@ -531,6 +531,150 @@ describe('condition test', () => { @@
                   await waitFor(() => expect(screen.getByLabelText('field2')).toHaveValue('set with then'));
                 });
+                test('should change fileds value by set funciton', async () => {

Contributor

rvsia Oct 12, 2022 •

edited

Loading

please use it instead of test, also a typo here

JuliePrazakova force-pushed the feature branch from 6d7bac3 to 843db93 Compare

October 13, 2022 07:57

JuliePrazakova requested a review from rvsia

October 13, 2022 07:58

JuliePrazakova force-pushed the feature branch from 843db93 to 955459a Compare

October 13, 2022 09:44

rvsia reviewed

View reviewed changes

packages/react-form-renderer/src/condition/condition.js Outdated

+                    Object.entries(setter).forEach(([name, value]) => {
+                      formOptions.change(name, value);
+                    });
+                  });

Contributor

rvsia Oct 18, 2022

We still need to keep an empty dependency array here: [] otherwise the function will be always re-created.

See here


          feat(renderer): enable condition set as a function

14de368

JuliePrazakova force-pushed the feature branch from 955459a to 14de368 Compare

October 18, 2022 09:35

JuliePrazakova requested a review from rvsia

October 18, 2022 09:36

rvsia approved these changes

View reviewed changes

rvsia assigned Hyperkid123

Hyperkid123 closed this

Hyperkid123 reopened this

Hyperkid123 merged commit 0ee0369 into data-driven-forms:master

Contributor

rvsia commented Oct 18, 2022

🎉 This PR is included in version 3.19.0 🎉

The release is available on

Data-Driven-Forms.org!

rvsia added the released label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released renderer