Skip to content
This repository was archived by the owner on May 17, 2024. It is now read-only.

Materialize: rename and reorder columns #287

Merged
merged 2 commits into from
Nov 14, 2022
Merged

Conversation

erezsh
Copy link
Contributor

@erezsh erezsh commented Nov 11, 2022

No description provided.

@leoebfolsom
Copy link
Contributor

leoebfolsom commented Nov 11, 2022

@erezsh does this also address not only the ordering, but also the point that I raised in Slack that

column names alternately use a/b and 1/2 to represent the left and right tables

Will they all now materialize as a/b instead of 1/2?

Edit reread the code and I think you've covered it--thanks!

@erezsh
Copy link
Contributor Author

erezsh commented Nov 14, 2022

@leoebfolsom Let me know if it behaves as you'd expect, so I can merge it in.

@leoebfolsom
Copy link
Contributor

This works as expected--thank you! @erezsh

@leoebfolsom leoebfolsom self-requested a review November 14, 2022 18:07
@leoebfolsom
Copy link
Contributor

@erezsh please merge when you're ready.

@erezsh erezsh merged commit 69e1154 into master Nov 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants