Skip to content
This repository was archived by the owner on May 17, 2024. It is now read-only.

Rudderstack poc #298

Merged
merged 3 commits into from
Nov 21, 2022
Merged

Rudderstack poc #298

merged 3 commits into from
Nov 21, 2022

Conversation

kylemcnair
Copy link
Contributor

@kylemcnair kylemcnair commented Nov 16, 2022

Switch tracking from Freshpaint to Rudderstack.

@kylemcnair kylemcnair self-assigned this Nov 16, 2022
@kylemcnair
Copy link
Contributor Author

Events successfully showing in Rudderstack
Screen Shot 2022-11-16 at 3 10 15 PM

@kylemcnair kylemcnair requested review from erezsh and dlawin November 17, 2022 21:09
@kylemcnair kylemcnair marked this pull request as ready for review November 17, 2022 21:09
@kylemcnair
Copy link
Contributor Author

I was unsure about exposing the write key and auth header in the repo. We previously exposed the Freshpaint token, but it doesn't seem like best practice.

@erezsh
Copy link
Contributor

erezsh commented Nov 17, 2022

@kylemcnair If you can think of a different approach, I'm all ears.

@kylemcnair
Copy link
Contributor Author

@kylemcnair If you can think of a different approach, I'm all ears.

@erezsh I don't have something in mind, but wanted to raise it. I talked to Dan about it, and don't think it's a blocking concern. I'll keep an eye out for alternatives and can always circle back in a subsequent PR.

@erezsh erezsh merged commit f79aba6 into master Nov 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants