Skip to content
This repository was archived by the owner on May 17, 2024. It is now read-only.

fix link to docs #330

Merged
merged 2 commits into from
Dec 5, 2022
Merged

Conversation

leoebfolsom
Copy link
Contributor

No description provided.

@leoebfolsom leoebfolsom requested a review from erezsh December 4, 2022 06:36
@erezsh
Copy link
Contributor

erezsh commented Dec 4, 2022

I think the link is more correct the way it is now.

@erezsh
Copy link
Contributor

erezsh commented Dec 4, 2022

What I mean, we should change it to https://docs.datafold.com/os_diff/how_to_use/how_to_use_with_command_line

Although I consider it a big flaw that https://docs.datafold.com/os_diff/how_to_use/ is an invalid URL

@leoebfolsom
Copy link
Contributor Author

leoebfolsom commented Dec 4, 2022

@erezsh please change it to https://docs.datafold.com/os_diff/how_to_use/how_to_use_with_command_line if you think that's better, and then merge it. We cannot wait all weekend to change a broken link in the readme, and I'm not available to debate right now. Thank you.

@leoebfolsom
Copy link
Contributor Author

@erezsh since I didn't hear from you, I updated the link based on your request.

@williebsweet williebsweet self-requested a review December 5, 2022 13:37
@williebsweet williebsweet merged commit 6f5417a into datafold:master Dec 5, 2022
@leoebfolsom leoebfolsom deleted the fix-link-to-docs branch December 5, 2022 14:57
@erezsh
Copy link
Contributor

erezsh commented Dec 6, 2022

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants