Skip to content

allow one-sided limit in scale_*_tint_*() #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Fan-iX
Copy link
Contributor

@Fan-iX Fan-iX commented Feb 25, 2025

Allowing limits=c(lower_limit, NA) or limits=c(NA, upper_limit) in scale_*_tint_*() functions.

For example, scale_fill_hypso_tint_c("gmt_globe", limits=c(0,NA)) will get the same effect as scale_fill_hypso_tint_c("gmt_globe_hypso")

Copy link

codecov bot commented Feb 25, 2025

Codecov Report

Attention: Patch coverage is 0% with 24 lines in your changes missing coverage. Please review.

Project coverage is 98.92%. Comparing base (7007704) to head (ad1c82f).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
R/scales_cross_blended.R 0.00% 8 Missing ⚠️
R/scales_grass.R 0.00% 8 Missing ⚠️
R/scales_hypso.R 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #170      +/-   ##
==========================================
- Coverage   99.64%   98.92%   -0.72%     
==========================================
  Files          50       50              
  Lines        3340     3364      +24     
==========================================
  Hits         3328     3328              
- Misses         12       36      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant