Skip to content

Add a CONTRIBUTING.md file for n00bs like me #1089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 30, 2020
Merged

Add a CONTRIBUTING.md file for n00bs like me #1089

merged 3 commits into from
Nov 30, 2020

Conversation

q0rban
Copy link

@q0rban q0rban commented Nov 24, 2020

No description provided.

Copy link
Member

@tianon tianon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks for figuring it out and taking a stab at writing some docs for it!

Just a few minor comments/suggestions 🙏

@q0rban
Copy link
Author

q0rban commented Nov 24, 2020

Thanks for the review @tianon ! I think I've made all the requested changes. Happy to tweak any of it.

Copy link
Member

@tianon tianon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 👍

@tianon tianon requested a review from yosifkit November 24, 2020 19:24
Co-authored-by: Tim Düsterhus <timwolla@googlemail.com>
@yosifkit yosifkit merged commit 20ebff4 into docker-library:master Nov 30, 2020
@q0rban q0rban deleted the add-contributing-md branch November 30, 2020 19:47
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Dec 17, 2020
Changes:

- docker-library/php@4908ef2: Remove 7.2 (EOL)
- docker-library/php@20ebff4: Merge pull request docker-library/php#1089 from q0rban/add-contributing-md
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Dec 18, 2020
Changes:

- docker-library/php@3db7191: Merge pull request docker-library/php#1104 from infosiftr/debian-cli-sapi
- docker-library/php@73ccb45: Add "--enable-embed" to Debian-based CLI variants
- docker-library/php@4908ef2: Remove 7.2 (EOL)
- docker-library/php@20ebff4: Merge pull request docker-library/php#1089 from q0rban/add-contributing-md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants