-
Notifications
You must be signed in to change notification settings - Fork 2k
Add a CONTRIBUTING.md file for n00bs like me #1089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thanks for figuring it out and taking a stab at writing some docs for it!
Just a few minor comments/suggestions 🙏
Thanks for the review @tianon ! I think I've made all the requested changes. Happy to tweak any of it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! 👍
Co-authored-by: Tim Düsterhus <timwolla@googlemail.com>
Changes: - docker-library/php@4908ef2: Remove 7.2 (EOL) - docker-library/php@20ebff4: Merge pull request docker-library/php#1089 from q0rban/add-contributing-md
Changes: - docker-library/php@3db7191: Merge pull request docker-library/php#1104 from infosiftr/debian-cli-sapi - docker-library/php@73ccb45: Add "--enable-embed" to Debian-based CLI variants - docker-library/php@4908ef2: Remove 7.2 (EOL) - docker-library/php@20ebff4: Merge pull request docker-library/php#1089 from q0rban/add-contributing-md
No description provided.