Use multi-arch node base image #105

RandomByte · 2018-02-11T15:29:42Z

As discussed in #102, change the main Dockerfile to use the muli-arch capable node:8-alpine image as base. This adds support for multiple architectures including ARM and makes some of the arch-specific Dockerfiles obsolete.

I tested this on a MacBook and Rasperry Pi 3 (ARMv8) without issues. I therefore went ahead and removed the Dockerfile.arm file and corresponding readme documentation.
If someone could confirm that the Dockerfile.aarch64 file is obsolete as well, we can remove it too.

I guess the Windows variant is still needed and could only be removed by adding build args to the main Dockerfile as @StefanScherer mentioned?

Btw. image size on Raspberry Pi is now down to 153MB (compared to 416MB with the old Dockerfile.arm)

The main Dockerfile is now ARM-compatible

alexellis · 2018-02-11T18:17:30Z

README.md

@@ -45,26 +45,8 @@ $ docker service create \
  dockersamples/visualizer
 ```

-## Running on ARM


You should not remove this section. Someone will still have to build and maintain an image on the Docker Hub.

alexellis

This won't automatically make the image work on any architecture - it'll only work on the platform it's built on unless lots of additional work is done to make this an official library image where CI is done for each platform and pushed under a multi-stage image.

I'd recommend not merging this PR.

StefanScherer · 2018-02-11T18:29:31Z

README.md

-
-[View on Docker Hub](https://hub.docker.com/r/alexellis2/visualizer-arm/tags/)
+## Supported architectures
+The main image is based on [node:8-alpine](https://hub.docker.com/_/node/). With that it already offers support for many architectures, including ARM (so it can run on your Raspberry Pi). See below for instructions on how to run on Windows.


This chapter should be more clear how to build the image for another architecture.
I assume there will be still only the linux/amd64 image as dockersamples/visualizer image.

So we need at least the docker build step how to build it locally and then use the commands above to start the visualizer.

RandomByte · 2018-02-11T19:35:51Z

I see, sorry for the misunderstanding. I updated the readme to make it clearer what to do for any given architecture and especially how to build. Please let me know what you think.

StefanScherer

I like the good overview of all Linux architectures.

StefanScherer · 2018-02-12T21:33:31Z

README.md

@@ -61,7 +71,7 @@ $ docker service create \
 If you would like to build the image from source run the following command:

 ```
-$ docker build -f Dockerfile.arm -t visualizer-arm:latest .
+$ docker build -f Dockerfile -t visualizer-arm:latest .


We can omit -f Dockerfile here.

StefanScherer · 2018-02-12T21:33:44Z

README.md

+
+To build an up-to-date image for any architecture supported by [node:8-alpine](https://hub.docker.com/_/node/) (currently `amd64`, `arm32v6`, `arm32v7`, `arm64v8`, `i386`, `ppc64le` and `s390x`), execute the following command on a device of your target architecture:
+```
+$ docker build -f Dockerfile -t visualizer-custom:latest .


We can omit -f Dockerfile here.

alexellis · 2018-02-16T08:38:58Z

README.md

+
+The main `dockersamples/visualizer` image supports **linux/amd64**.
+
+**For ARM**, there is a pre-built image available. See [Running on ARM](#running-on-arm).


We should be more specific about "arm" - this works for armhf only, it won't work for 64-bit ARM such as that found on Packet's or Scaleway's servers or the Pine64 etc.

Makes sense. Done 👍

RandomByte · 2018-04-02T09:58:12Z

Any further objections @alexellis, @StefanScherer?

StefanScherer · 2018-04-02T18:11:35Z

Seems good to me.

RandomByte · 2018-06-11T20:54:35Z

@alexellis any update from your side?

StefanScherer · 2019-01-02T19:49:34Z

@RandomByte I have some time to test your PR. Can you remove the Dockerfile.aarch64 as well? It is obsolete with your PR as well.

Someone on a RPi Zero/1 can build it, someone else can use the same Dockerfile on RPi3 64bit or on another ARM64 board and build it.

StefanScherer · 2019-01-02T20:49:23Z

The build works as well as the visualizer on

Docker Desktop on macOS to build a linux/amd64 image
Raspberry Pi 3 with Raspbian or HypriotOS 32bit to build the linux/armv6 image
Raspberry Pi 1 (yes, the old one with 1/2 GByte RAM, I just found a compatible 4 GByte SD card) to slowly 😴 build linux/armv6 image
Raspberry Pi 3 with HypriotOS 64bit to build the linux/arm64 image

One Dockerfile to rule them all. 🎉

As mentioned above this one docker build -t visualizer . does not create a multi-arch image, just one image that fits the current platform. I've pushed all images built to the Docker Hub hypriot/visualizer repo so everyone can get some ARM images from there.

LGTM!

@ManoMarks We can remove the Dockerfile.aarch64 file after merging this.

ManoMarks · 2019-01-02T20:51:54Z

Thanks @StefanScherer!

RandomByte added 2 commits February 11, 2018 15:46

Use multi-arch node:8-alpine as base image

4ffb5d1

Remove Dockerfile.arm

3d28a24

The main Dockerfile is now ARM-compatible

RandomByte mentioned this pull request Feb 11, 2018

[ARM] Use arm32v6/node alpine base image #102

Closed

alexellis reviewed Feb 11, 2018

View reviewed changes

alexellis suggested changes Feb 11, 2018

View reviewed changes

StefanScherer reviewed Feb 11, 2018

View reviewed changes

Explain custom build and re-add ARM image reference

f180e56

RandomByte force-pushed the use-multi-arch-node-base-image branch from 5df2f52 to f180e56 Compare February 11, 2018 19:33

StefanScherer reviewed Feb 12, 2018

View reviewed changes

Readme: Omit '-f Dockerfile' where not needed

f891f2e

alexellis reviewed Feb 16, 2018

View reviewed changes

Readme: Differentiate between ARM and armhf

7acef58

StefanScherer mentioned this pull request Jan 2, 2019

Arm64v8 update (i.e. for Raspberry Pi 3 clusters) #121

Closed

ManoMarks merged commit d46b2ad into dockersamples:master Jan 2, 2019

ManoMarks mentioned this pull request Jan 2, 2019

Vsualizer for Arm #112

Closed

StefanScherer mentioned this pull request Jan 2, 2019

Remove Dockerfile.aarch64, use Dockerfile instead #126

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Use multi-arch node base image #105

Use multi-arch node base image #105

Uh oh!

RandomByte commented Feb 11, 2018

Uh oh!

alexellis Feb 11, 2018

Uh oh!

alexellis left a comment

Uh oh!

StefanScherer Feb 11, 2018

Uh oh!

RandomByte commented Feb 11, 2018

Uh oh!

StefanScherer left a comment

Uh oh!

StefanScherer Feb 12, 2018

Uh oh!

StefanScherer Feb 12, 2018

Uh oh!

alexellis Feb 16, 2018

Uh oh!

RandomByte Feb 17, 2018

Uh oh!

RandomByte commented Apr 2, 2018

Uh oh!

StefanScherer commented Apr 2, 2018

Uh oh!

RandomByte commented Jun 11, 2018 •

edited

Loading

Uh oh!

StefanScherer commented Jan 2, 2019

Uh oh!

StefanScherer commented Jan 2, 2019

Uh oh!

ManoMarks commented Jan 2, 2019

Uh oh!

Uh oh!


		The main `dockersamples/visualizer` image supports linux/amd64.

		For ARM, there is a pre-built image available. See [Running on ARM](#running-on-arm).

Use multi-arch node base image #105

Use multi-arch node base image #105

Uh oh!

Conversation

RandomByte commented Feb 11, 2018

Uh oh!

alexellis Feb 11, 2018

Choose a reason for hiding this comment

Uh oh!

alexellis left a comment

Choose a reason for hiding this comment

Uh oh!

StefanScherer Feb 11, 2018

Choose a reason for hiding this comment

Uh oh!

RandomByte commented Feb 11, 2018

Uh oh!

StefanScherer left a comment

Choose a reason for hiding this comment

Uh oh!

StefanScherer Feb 12, 2018

Choose a reason for hiding this comment

Uh oh!

StefanScherer Feb 12, 2018

Choose a reason for hiding this comment

Uh oh!

alexellis Feb 16, 2018

Choose a reason for hiding this comment

Uh oh!

RandomByte Feb 17, 2018

Choose a reason for hiding this comment

Uh oh!

RandomByte commented Apr 2, 2018

Uh oh!

StefanScherer commented Apr 2, 2018

Uh oh!

RandomByte commented Jun 11, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

StefanScherer commented Jan 2, 2019

Uh oh!

StefanScherer commented Jan 2, 2019

Uh oh!

ManoMarks commented Jan 2, 2019

Uh oh!

Uh oh!

RandomByte commented Jun 11, 2018 •

edited

Loading