Fix missing RecognizesAccessKey property on Fluent controls #10073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
requested review from
dipeshmsft,
singhashish-wpf and
Kuldeep-MS
dotnet-policy-service
bot
added
PR
|
LGTM, @h3xds1nz can you please resolve the merge conflicts? |
h3xds1nz
force-pushed
the
fix-fluent-accesskeys
branch
from
1e7daf8 to
889e70c
Compare
|
@siagupta0202 Should be alright :) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10073 +/- ##
===================================================
+ Coverage 10.99508% 11.40400% +0.40892%
===================================================
Files 3215 3214 -1
Lines 648472 648518 +46
Branches 71534 71516 -18
===================================================
+ Hits 71300 73957 +2657
+ Misses 576170 573398 -2772
- Partials 1002 1163 +161
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
siagupta0202
approved these changes
Mar 6, 2025
Thank you so much for your contributions! |
|
@siagupta0202 Thank you :) Happy to help! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10071
Description
Fixes missing
RecognizesAccessKeyproperty on some Fluent controls that I found to be lacking based on the original issue.Customer Impact
Users will get less buggy experience migrating to Fluent Theme.
Regression
Kinda, from previous themes.
Testing
Local build, sample app.
Risk
None.
Microsoft Reviewers: Open in CodeFlow