Use shared DataFormats code #10391
Merged
Use shared DataFormats code #10391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses the shared DataFormats code from System.Private.Windows.Core. Note that locking is handled by the shared code so there is no need to do so when adding the WPF specific types. The only reason they need added is that casing will stick with whatever the first request is. That is, if you ask for "XAML" that will be the string Windows gives back, not "Xaml".
dotnet-policy-service
bot
requested review from
dipeshmsft,
singhashish-wpf and
Kuldeep-MS
dotnet-policy-service
bot
added
the
PR
miloush
reviewed
Feb 4, 2025
src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/DataFormats.cs
Show resolved
Hide resolved
|
Where can I see the value of |
@miloush You have to go to def in VS, this is all source generated. It comes indirectly from the Windows headers. In this particular case it isn't in the docs that I can find (very unusual), just the headers. The value is "Ink Serialized Format". |
Kuldeep-MS
reviewed
Feb 10, 2025
src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/dataobject.cs
Show resolved
Hide resolved
Kuldeep-MS
reviewed
Mar 5, 2025
Kuldeep-MS
approved these changes
Mar 5, 2025
The primary refactoring was dotnet/winforms#12802. The shared code had a number of other edits past that. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the shared DataFormats code from System.Private.Windows.Core.
Note that locking is handled by the shared code so there is no need to do so when adding the WPF specific types. The only reason they need added is that casing will stick with whatever the first request is. That is, if you ask for "XAML" that will be the string Windows gives back, not "Xaml".
Microsoft Reviewers: Open in CodeFlow