-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Sync MilCodeGen to generated code #10430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync MilCodeGen to generated code #10430
Conversation
Contributes to dotnet#10429
As per IDE0073 we do not have to include the third line of the header as in Style.cs , EmptyFileHelper.cs generators. But you included it here, is it reduce the diff in generation and will be handled by other MilCodeGen PRs ? |
Yes, I went with what most files used to reduce the diff and removing the third line of the header could be done in a followup PR. |
I can just resync my PR afterwards. |
src/Microsoft.DotNet.Wpf/src/WpfGfx/codegen/mcg/generators/CommandType.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.Wpf/src/WpfGfx/codegen/mcg/generators/ManagedEnum.cs
Show resolved
Hide resolved
src/Microsoft.DotNet.Wpf/src/WpfGfx/codegen/mcg/generators/ManagedResource.cs
Show resolved
Hide resolved
src/Microsoft.DotNet.Wpf/src/WpfGfx/codegen/mcg/generators/DuceResource.cs
Show resolved
Hide resolved
@dipeshmsft Thanks for the review, I pushed a commit that reintroduces the commented assert. I won't rebase my other PRs onto this PR just for that since it's a minor change that doesn't affect the generated code. |
Thanks @ThomasGoulet73 for this contribution. I will move ahead to other PRs now. |
Thanks @dipeshmsft, I'll rebase my other PRs. |
Contributes to #10429
Description
Syncs MilCodeGen to the generated code. This makes it as close as possible to reduce the diff and include changes that were made in the generated code.
Customer Impact
None, this does not affect shipping code.
Regression
No.
Testing
Local build + CI + I manually validated the generated code.
Risk
Now to none, this does not affect shipping code.
Microsoft Reviewers: Open in CodeFlow