Skip to content

Sync MilCodeGen to generated code #10430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ThomasGoulet73
Copy link
Contributor

@ThomasGoulet73 ThomasGoulet73 commented Feb 8, 2025

Contributes to #10429

Description

Syncs MilCodeGen to the generated code. This makes it as close as possible to reduce the diff and include changes that were made in the generated code.

Customer Impact

None, this does not affect shipping code.

Regression

No.

Testing

Local build + CI + I manually validated the generated code.

Risk

Now to none, this does not affect shipping code.

Microsoft Reviewers: Open in CodeFlow

@ThomasGoulet73 ThomasGoulet73 requested review from a team as code owners February 8, 2025 05:53
@dotnet-policy-service dotnet-policy-service bot added PR metadata: Label to tag PRs, to facilitate with triage Community Contribution A label for all community Contributions labels Feb 8, 2025
@ThomasGoulet73
Copy link
Contributor Author

ThomasGoulet73 commented Feb 8, 2025

I'll open PRs where I update the generated code in a few minutes, it's easier to review the generated code than to review the changes to code generators (This PR).

Edit:
Here's the list of PRs to help review this PR:
#10431
#10432
#10433
#10434
#10435

@dipeshmsft
Copy link
Member

As per IDE0073 we do not have to include the third line of the header as in Style.cs , EmptyFileHelper.cs generators. But you included it here, is it reduce the diff in generation and will be handled by other MilCodeGen PRs ?

@ThomasGoulet73
Copy link
Contributor Author

As per IDE0073 we do not have to include the third line of the header as in Style.cs , EmptyFileHelper.cs generators. But you included it here, is it reduce the diff in generation and will be handled by other MilCodeGen PRs ?

Yes, I went with what most files used to reduce the diff and removing the third line of the header could be done in a followup PR.

@h3xds1nz
Copy link
Member

h3xds1nz commented Feb 8, 2025

I can just resync my PR afterwards.

@ThomasGoulet73
Copy link
Contributor Author

@dipeshmsft Thanks for the review, I pushed a commit that reintroduces the commented assert. I won't rebase my other PRs onto this PR just for that since it's a minor change that doesn't affect the generated code.

@dipeshmsft dipeshmsft merged commit 23c6b65 into dotnet:main Feb 11, 2025
8 checks passed
@dipeshmsft
Copy link
Member

Thanks @ThomasGoulet73 for this contribution. I will move ahead to other PRs now.

@ThomasGoulet73
Copy link
Contributor Author

Thanks @dipeshmsft, I'll rebase my other PRs.

@ThomasGoulet73 ThomasGoulet73 deleted the sync-MilCodeGen-to-generated-code branch February 11, 2025 05:54
@dipeshmsft dipeshmsft added this to the .NET 10 milestone Feb 19, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2025
@dipeshmsft dipeshmsft modified the milestones: .NET 10, 10.0.0 Apr 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Community Contribution A label for all community Contributions PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants